Skip to content

Fix an issue with an instant crash for invalid xml in TiGLCreator#1322

Merged
svengoldberg merged 7 commits into
mainfrom
994-tigl-viewer-crashes-without-report-when-xml-not-valid
Jun 11, 2026
Merged

Fix an issue with an instant crash for invalid xml in TiGLCreator#1322
svengoldberg merged 7 commits into
mainfrom
994-tigl-viewer-crashes-without-report-when-xml-not-valid

Conversation

@joergbrech

@joergbrech joergbrech commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes #994. If you add an xml node without content, TIGL crashes. The reason is that in the generated code, only existence of tixi elements is checked, not if the tixi element has any text contents.

To fix this, we need to fix the check in the generated code and regenerate all the files. Therefore this PR depends on DLR-SC/cpacs_tigl_gen#9 to be merged first. The changes in this PR are just regenerated src files with the updated cpacs_gen version.

To Do:

How Has This Been Tested?

Since this is a TiGLCreator issue it was only tested manually with the TiGLCreator. The test file in the issue description logs an error, but the geometry can be generated and TiGLCreator does not crash anymore.

Screenshots, that help to understand the changes(if applicable):

Checklist:

Task Finished Reviewer Approved
At least one test for the new functionality was added.
  • yes
  • does not apply
  • OK
New classes have been added to the Python interface.
  • yes
  • does not apply
  • OK
The code is properly documented with doxygen docstrings
  • yes
  • does not apply
  • OK
Changes are documented at the top of ChangeLog.md
  • yes
  • does not apply
  • OK

@joergbrech joergbrech linked an issue Jun 10, 2026 that may be closed by this pull request
@joergbrech joergbrech requested a review from svengoldberg June 10, 2026 15:47
@joergbrech joergbrech marked this pull request as draft June 10, 2026 15:52
@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.58%. Comparing base (09375d1) to head (9e36890).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1322   +/-   ##
=======================================
  Coverage   72.58%   72.58%           
=======================================
  Files         316      316           
  Lines       27750    27750           
=======================================
  Hits        20141    20141           
  Misses       7609     7609           
Flag Coverage Δ
unittests 72.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joergbrech joergbrech marked this pull request as ready for review June 10, 2026 18:06

@svengoldberg svengoldberg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@svengoldberg svengoldberg merged commit 7696964 into main Jun 11, 2026
16 checks passed
@svengoldberg svengoldberg deleted the 994-tigl-viewer-crashes-without-report-when-xml-not-valid branch June 11, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tigl viewer crashes without report when xml not valid

2 participants