Fix an issue with an instant crash for invalid xml in TiGLCreator#1322
Merged
svengoldberg merged 7 commits intoJun 11, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1322 +/- ##
=======================================
Coverage 72.58% 72.58%
=======================================
Files 316 316
Lines 27750 27750
=======================================
Hits 20141 20141
Misses 7609 7609
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #994. If you add an xml node without content, TIGL crashes. The reason is that in the generated code, only existence of tixi elements is checked, not if the tixi element has any text contents.
To fix this, we need to fix the check in the generated code and regenerate all the files. Therefore this PR depends on DLR-SC/cpacs_tigl_gen#9 to be merged first. The changes in this PR are just regenerated src files with the updated cpacs_gen version.
To Do:
How Has This Been Tested?
Since this is a TiGLCreator issue it was only tested manually with the TiGLCreator. The test file in the issue description logs an error, but the geometry can be generated and TiGLCreator does not crash anymore.
Screenshots, that help to understand the changes(if applicable):
Checklist: