CPACS XSD: Move wrong node type restriction into element attribute#1325
Draft
svengoldberg wants to merge 1 commit into
Draft
CPACS XSD: Move wrong node type restriction into element attribute#1325svengoldberg wants to merge 1 commit into
svengoldberg wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1325 +/- ##
=======================================
Coverage 72.58% 72.58%
=======================================
Files 316 316
Lines 27750 27750
=======================================
Hits 20141 20141
Misses 7609 7609
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: Choose new CPACS XSD as basis...
Wait for DLR-SL/CPACS#864 to be merged!
The new CPACS node for the
approximationSettingsbrings a node structure that introduces a wrong type restriction.This did not stand out within the code generator or TiGL but within the mentioned CPACS PR.
To avoid several PR for potential more changes within the CPACS repo, do not merge this PR before the other one is done.
Fix #1324.
Description
How Has This Been Tested?
Screenshots, that help to understand the changes(if applicable):
Checklist: