Skip to content

Fix the sweep and dihedral chord percantage spinbox for wing elements#1327

Merged
joergbrech merged 3 commits into
mainfrom
1221_fix_wing_sweep_dihedral_chord_percantage_spinbox
Jun 11, 2026
Merged

Fix the sweep and dihedral chord percantage spinbox for wing elements#1327
joergbrech merged 3 commits into
mainfrom
1221_fix_wing_sweep_dihedral_chord_percantage_spinbox

Conversation

@svengoldberg

Copy link
Copy Markdown
Contributor

This PR fixes the wrong behaviour of the spinboxes that adjust the wing sweep and dihedral chord percantages.
Here, default values were set hard-wired that overwrote the user selection.
Moreover, during the internal update, the sweep computation used the wrong spinbox value.

Fix #1221.

Description

How Has This Been Tested?

Screenshots, that help to understand the changes(if applicable):

Checklist:

Task Finished Reviewer Approved
At least one test for the new functionality was added.
  • yes
  • does not apply
  • OK
New classes have been added to the Python interface.
  • yes
  • does not apply
  • OK
The code is properly documented with doxygen docstrings
  • yes
  • does not apply
  • OK
Changes are documented at the top of ChangeLog.md
  • yes
  • does not apply
  • OK

@svengoldberg svengoldberg requested a review from joergbrech June 11, 2026 14:06
@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.96%. Comparing base (8350f01) to head (eb48c2f).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1327   +/-   ##
=======================================
  Coverage   72.96%   72.96%           
=======================================
  Files         322      322           
  Lines       28290    28290           
=======================================
  Hits        20643    20643           
  Misses       7647     7647           
Flag Coverage Δ
unittests 72.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joergbrech joergbrech left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@joergbrech joergbrech merged commit 60489af into main Jun 11, 2026
16 checks passed
@joergbrech joergbrech deleted the 1221_fix_wing_sweep_dihedral_chord_percantage_spinbox branch June 11, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TiGLCreator 3.5 define wing chord % does not work

2 participants