Fix the sweep and dihedral chord percantage spinbox for wing elements#1327
Merged
joergbrech merged 3 commits intoJun 11, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1327 +/- ##
=======================================
Coverage 72.96% 72.96%
=======================================
Files 322 322
Lines 28290 28290
=======================================
Hits 20643 20643
Misses 7647 7647
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the wrong behaviour of the spinboxes that adjust the wing sweep and dihedral chord percantages.
Here, default values were set hard-wired that overwrote the user selection.
Moreover, during the internal update, the sweep computation used the wrong spinbox value.
Fix #1221.
Description
How Has This Been Tested?
Screenshots, that help to understand the changes(if applicable):
Checklist: