use FitCurveOptimal to improve approximation quality of approximated point list profiles#1329
Open
joergbrech wants to merge 2 commits into
Open
use FitCurveOptimal to improve approximation quality of approximated point list profiles#1329joergbrech wants to merge 2 commits into
joergbrech wants to merge 2 commits into
Conversation
…point list profiles. Addresses #1320
…xplicit error is probably not a good test...
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1329 +/- ##
=======================================
Coverage 72.96% 72.97%
=======================================
Files 322 322
Lines 28290 28292 +2
=======================================
+ Hits 20643 20645 +2
Misses 7647 7647
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses #1320. Switching to FitCurveOptimal results in a much better control point distribution. Not adding a release note entry as it doesn't add any functionality on top of #1277, which has a release note entry already.
This PR does not fix the issue of excessive knot insertion in the pre-processing of the profile curves before lofting.
How Has This Been Tested?
Tested on a variant of the BWB model in the digital hangar. Approximation quality is greatly improved.
Screenshots, that help to understand the changes(if applicable):
Checklist: