Skip to content

use FitCurveOptimal to improve approximation quality of approximated point list profiles#1329

Open
joergbrech wants to merge 2 commits into
mainfrom
1320-FitCurveOptiomal
Open

use FitCurveOptimal to improve approximation quality of approximated point list profiles#1329
joergbrech wants to merge 2 commits into
mainfrom
1320-FitCurveOptiomal

Conversation

@joergbrech

Copy link
Copy Markdown
Contributor

Description

Addresses #1320. Switching to FitCurveOptimal results in a much better control point distribution. Not adding a release note entry as it doesn't add any functionality on top of #1277, which has a release note entry already.

This PR does not fix the issue of excessive knot insertion in the pre-processing of the profile curves before lofting.

How Has This Been Tested?

Tested on a variant of the BWB model in the digital hangar. Approximation quality is greatly improved.

Screenshots, that help to understand the changes(if applicable):

image image

Checklist:

Task Finished Reviewer Approved
At least one test for the new functionality was added.
  • yes
  • does not apply
  • OK
New classes have been added to the Python interface.
  • yes
  • does not apply
  • OK
The code is properly documented with doxygen docstrings
  • yes
  • does not apply
  • OK
Changes are documented at the top of ChangeLog.md
  • yes
  • - [ x] does not apply
  • OK

@joergbrech joergbrech requested a review from svengoldberg June 16, 2026 10:17
@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.97%. Comparing base (60489af) to head (75721ff).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1329   +/-   ##
=======================================
  Coverage   72.96%   72.97%           
=======================================
  Files         322      322           
  Lines       28290    28292    +2     
=======================================
+ Hits        20643    20645    +2     
  Misses       7647     7647           
Flag Coverage Δ
unittests 72.97% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/fuselage/CCPACSFuselageProfile.cpp 87.50% <100.00%> (+0.05%) ⬆️
src/geometry/CTiglApproximateBsplineWire.cpp 61.66% <100.00%> (+0.32%) ⬆️
src/geometry/CTiglBSplineApproxInterp.cpp 96.98% <100.00%> (ø)
src/geometry/CTiglBSplineApproxInterp.h 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant