Conversation
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
clalancette
approved these changes
Aug 30, 2024
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
This looks good to me. I'll note that this should work fine going all the way back to Humble, so it should be safe to merge in regardless of the branching strategy used in this repository.
Contributor
Author
|
@DLu do you mind to take a quick look ? |
Owner
|
Thank you for taking the time to propagate downstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related with ros2/demos#701 (comment) and ros2/demos#702