Update README and schema documentation for SDA Host Port Onboarding C…#147
Update README and schema documentation for SDA Host Port Onboarding C…#147thievo552000 wants to merge 1 commit into
Conversation
…onfig Generator - Expanded README to include detailed sections on workflow capabilities, prerequisites, input data model, and operational behavior. - Added examples for input configurations and clarified usage instructions. - Updated schema to include new append mode feature and detailed validation rules for component-specific filters.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f12ab4519f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Wireless SSIDs filters | ||
| wireless_ssids: include('fabric_site_filter_type', required=False) | ||
| # Wireless SSIDs filters (fabric site filter only) | ||
| wireless_ssids: include('fabric_site_filter_type', required=true) |
There was a problem hiding this comment.
Setting wireless_ssids to required=true makes schema validation fail for any selective export that only targets port_assignments or port_channels. In this workflow, many valid inputs provide component_specific_filters without a wireless_ssids block, so this change blocks those runs at validation time instead of allowing optional component filters.
Useful? React with 👍 / 👎.
| # Port channels filters | ||
| port_channels: include('fabric_site_filter_type', required=False) |
There was a problem hiding this comment.
The commit introduces device_filter_type and documents device_ips, serial_numbers, and hostnames, but port_assignments and port_channels still reference fabric_site_filter_type. As a result, inputs that follow the new documentation will be rejected by schema validation because those device-level keys are not allowed under the currently referenced type.
Useful? React with 👍 / 👎.
1 participant
…onfig Generator