Add namespace to base class to resolve compile errors with certain co…

[jwillemsen]

…mpilers

* ACE/protocols/ace/INet/HTTPS_Session.cpp:

Summary by CodeRabbit

• Bug Fixes
  • Improved HTTPS session initialization for more reliable connection handling.

[jwillemsen]

@Mergifyio backport ace6tao2

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 74d2d350-a9d0-4959-828c-33e1f312a066

📥 Commits

Reviewing files that changed from the base of the PR and between 354177e and 0a3b491.

📒 Files selected for processing (1)

• ACE/protocols/ace/INet/HTTPS_Session.cpp

---

Walkthrough

The two Session_T constructors now explicitly initialize ACE::HTTP::SessionBase. Constructor parameters and initialization behavior remain unchanged.

Changes

HTTPS session initialization

Layer / File(s)	Summary
Constructor base-class qualification ACE/protocols/ace/INet/HTTPS_Session.cpp	Both Session_T constructors use the fully qualified ACE::HTTP::SessionBase initializer.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Mergeability Score: ⚪ Minimal · up to 0a3b4

This is a small, localized namespace adjustment intended to resolve compiler compatibility issues; no actionable merge-blocking risk remains beyond normal checks and review.

Poem

A rabbit checks the base class line,
Now ACE::HTTP makes it clear and fine.
Two constructors hop in place,
With unchanged steps and steady pace.
Qualification wins the day!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the namespace qualification change and its purpose of resolving compiler errors.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[mergify]

backport ace6tao2

✅ Backports have been created

Details

• #2558 Add namespace to base class to resolve compile errors with certain co… (backport #2557) has been created for branch ace6tao2

[mergify]

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

• Queue this pull request

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}