Always use params_dup.cpp

[jwillemsen]

* TAO/orbsvcs/orbsvcs/SSLIOP/params_dup.c:
* TAO/orbsvcs/orbsvcs/ssliop_params_dup.mpb: Deleted.

* TAO/orbsvcs/orbsvcs/SSLIOP.mpc:
* TAO/orbsvcs/orbsvcs/SSLIOP/params_dup.cpp:

Summary by CodeRabbit

• Refactor
  • Updated SSLIOP’s build configuration to use the C++ implementation for SSL parameter handling.
  • Removed the obsolete duplicate C implementation and its standalone build configuration.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 666379dd-86f6-41e4-9995-9f57de784b5e

📥 Commits

Reviewing files that changed from the base of the PR and between dfd0e83 and c20114e.

📒 Files selected for processing (4)

• TAO/orbsvcs/orbsvcs/SSLIOP.mpc
• TAO/orbsvcs/orbsvcs/SSLIOP/params_dup.c
• TAO/orbsvcs/orbsvcs/SSLIOP/params_dup.cpp
• TAO/orbsvcs/orbsvcs/ssliop_params_dup.mpb

💤 Files with no reviewable changes (3)

• TAO/orbsvcs/orbsvcs/ssliop_params_dup.mpb
• TAO/orbsvcs/orbsvcs/SSLIOP/params_dup.cpp
• TAO/orbsvcs/orbsvcs/SSLIOP/params_dup.c

---

Walkthrough

The SSLIOP build no longer uses the separate ssliop_params_dup project. It now compiles params_dup.cpp as part of the SSLIOP component. Related standalone source and project files were removed.

Changes

SSLIOP build integration

Layer / File(s)	Summary
Direct parameter-duplication source integration TAO/orbsvcs/orbsvcs/SSLIOP.mpc, TAO/orbsvcs/orbsvcs/SSLIOP/params_dup.cpp, TAO/orbsvcs/orbsvcs/SSLIOP/params_dup.c, TAO/orbsvcs/orbsvcs/ssliop_params_dup.mpb	The SSLIOP build removes the separate project dependency and adds params_dup.cpp directly. The obsolete C source and project configuration are deleted.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Mergeability Score: ⚪ Minimal · up to c2011

The change standardizes use of the C++ implementation and removes the obsolete C/build configuration files; no actionable merge-blocking risk remains after normal checks and review.

Poem

A rabbit hops through SSLIOP’s build,
With C++ sources neatly filled.
The old project fades away,
params_dup.cpp joins the day.
Sniff, compile, and cheer—
A tidy change is here!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: using params_dup.cpp exclusively.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[mergify]

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

• Queue this pull request

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric	Results
Complexity	0

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}