Skip to content

In debug mode log in some more places the OpenSSL underlying error - #2560

Merged
jwillemsen merged 1 commit into
DOCGroup:masterfrom
jwillemsen:jwi-sslcontexterrorreporting
Aug 14, 2026
Merged

In debug mode log in some more places the OpenSSL underlying error#2560
jwillemsen merged 1 commit into
DOCGroup:masterfrom
jwillemsen:jwi-sslcontexterrorreporting

Conversation

@jwillemsen

@jwillemsen jwillemsen commented Aug 14, 2026

Copy link
Copy Markdown
Member
* ACE/ace/SSL/SSL_Context.cpp:

Summary by CodeRabbit

  • Bug Fixes
    • Improved SSL certificate and private-key validation diagnostics when debugging is enabled.
    • OpenSSL error details are now reported for certificate, certificate-chain, and key verification failures.

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8b85d2ea-d740-46c4-84e7-9e5c2b7ef5b1

📥 Commits

Reviewing files that changed from the base of the PR and between dfd0e83 and 3e1bfbc.

📒 Files selected for processing (1)
  • ACE/ace/SSL/SSL_Context.cpp

Walkthrough

SSL private-key, certificate, and certificate-chain failure paths now conditionally report OpenSSL errors when ACE debugging is enabled. Private-key verification uses an explicit failure branch while preserving existing return values and cleanup.

Changes

SSL error reporting

Layer / File(s) Summary
Conditional OpenSSL diagnostics
ACE/ace/SSL/SSL_Context.cpp
Private-key loading, private-key verification, certificate loading, in-memory certificate installation, and certificate-chain loading now report OpenSSL errors before returning failure when debugging is enabled.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 3e1bf

This is a localized debug logging change with no actionable merge-blocking risk remaining after normal checks and review.

Poem

I’m a rabbit with a key,
Watching SSL errors flee.
Certificates speak clear,
OpenSSL logs appear.
Failures keep their proper way—
Debugging helps them shine today.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: logging additional underlying OpenSSL errors in debug mode.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 5 complexity

Metric Results
Complexity 5

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@mergify

mergify Bot commented Aug 14, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@jwillemsen
jwillemsen merged commit aebba0f into DOCGroup:master Aug 14, 2026
39 checks passed
@jwillemsen
jwillemsen deleted the jwi-sslcontexterrorreporting branch August 14, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant