Update tests to support data.gov data transfers#185
Merged
Conversation
…n titles for data.gov
RobLBaker
added
documentation
wright13
reviewed
May 19, 2026
| indicate improper formatting. Otherwise the test passes. | ||
| abstract. The test Fails with an error if the abstract is absent or | ||
| greater than 10,000 characters (required for data.gov). If the abstract | ||
| is present, the test fails with a warning if the abstract is \<20 words, |
Collaborator
There was a problem hiding this comment.
Should this be "passes with a warning"?
Member
Author
There was a problem hiding this comment.
Definitely... I think I fixed it, but if not I'll get it in the next round.
wright13
reviewed
May 19, 2026
wright13
reviewed
May 19, 2026
| #' @inheritParams test_pub_date | ||
| #' | ||
| #' @return invisilbe(meatadatda) | ||
| #' @return invisible(meatadatda) |
Member
Author
There was a problem hiding this comment.
Haha! how did I see invisilbe but not meatdata?
wright13
reviewed
May 19, 2026
wright13
approved these changes
May 19, 2026
wright13
left a comment
wright13
left a comment
Collaborator
There was a problem hiding this comment.
Consider changing language from "fails with warning" to "succeeds with warning." Made a few suggestions for more precise language and typo fixes. Good to merge once these are addressed!
Co-authored-by: Sarah Wright <sewright@nps.gov>
Corrected the test behavior description for the abstract length and formatting checks.
Co-authored-by: Sarah Wright <sewright@nps.gov>
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #183