Adds support for accessing COG shape models from STAC API#5985
Adds support for accessing COG shape models from STAC API#5985amystamile-usgs wants to merge 14 commits intoDOI-USGS:devfrom
Conversation
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5985". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
1 similar comment
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5985". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5985". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5985". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5985". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
|
GET requests are working but POST are still not working. Waiting on eSAS to fix on their end. |
POST is now working. PR should be ready for review. |
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5985". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
| else { | ||
| dem = baseKernels.dem(lab); | ||
| } |
There was a problem hiding this comment.
I think if this case is reached we might want to at least warn the user that the web service is unavailable.
There was a problem hiding this comment.
I think we can add a waning message facility similar to how we said we would handle deprecation messages:
https://astrogeology.usgs.gov/docs/how-to-guides/software-management/deprecation/
| kernelSuccess = tryKernels(icube, p, ui, log, lk, pck, targetSpk, | ||
| realCkKernel, fk, ik, sclk, spk, iak, dem, exk); |
There was a problem hiding this comment.
I'm trying to think of a better way to handle this. I understand why we need to run tryKernels a second time but it's not ideal
Description
This PR is waiting on WAF URL to be added - https://astrogeology.usgs.gov/apis/isis-stac
Related Issue
ISIS Cloud
How Has This Been Validated?
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: