QApps Add Projection Selection#6000
Conversation
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_6000". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
amystamile-usgs
left a comment
amystamile-usgs
left a comment
There was a problem hiding this comment.
Needs changelog entry as well.
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_6000". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
|
Is there a dialog box (continuously) shown somewhere that indicates whether the geometry source is the camera model or projection? I think that would be nice to have if there isn't one (e.g, qview). |
|
@KrisBecker Yes, I was meaning to include some screenshots since this is a gui change |
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_6000". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
* Add check for ugm pointer validity before accessing the camera * Add the ability to select either the camera or projection to use in findtool * Remove leftover couts from UGM class * Addressed wording for function description * Change UGM::Radius to UGM::LocalRadius and fix doc string * Fix typo in new combobox function string * Fix GroundGrid to properly handle new UGM priority * Fix SpatialPlotTool to handle new UGM priority * Small fix to UGM test
3 participants
Description
Issues arise when comparing cameras to map projected images in qview, and likely other ISIS QApps. As noted in issues in the related issues sections. Projected images where scaling differently when compared to the associated images with just a camera model. This is due to the
distancePerPixelmethod in the FindTool.There are two situations to consider with this problem:
The FindTool requests the radii from either the camera or the projection depending on what is present. The old behavior always used the camera which is fine for situation 1.
There are instances in ISIS where one can create an identical projected product but remove the old camera information (automos, and other mosaic apps where only one image is used). In these cases comparing a camera to the projection in the old code resulted in scale disparities, see the UniversalGroundMap class and the FindTool classes
distancePerPixelfunction. This issue arose in situation 2.If we fix situation 2 by forcing to use the projection as the priority we introduce the same bug/issues into situation 1.
This PR allows users to select the projection priority so that both situations can be accessed by users.
Related Issue
#5896
#5508
How Has This Been Validated?
Validated locally
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: