changed bug-causing filter arg to bbox_filter in load_nhdplus_hr#212
Open
jknightusgs wants to merge 2 commits intoDOI-USGS:developfrom
Open
changed bug-causing filter arg to bbox_filter in load_nhdplus_hr#212jknightusgs wants to merge 2 commits intoDOI-USGS:developfrom
jknightusgs wants to merge 2 commits intoDOI-USGS:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I modified a single line in nhdplus_utils.py where the function load_nhdplus_hr() makes a call to the function read_nhdplus_hr() using the deprecated "filter" argument instead of the updated "bbox_filter" argument. This only causes a bug when NHDPlusHR_paths is provided as a string or path. When provided as a list, the call to read_nhdplus_hr() uses the updated bbox_filter arg.
I'm just getting my feet wet learning how to contribute to existing code repositories, and this seemed like a simple case to try it out. Hopefully the steps I followed from a rudimentary google search were sufficient, and this is more helpful than burdensome.