fix(ci): sync-upstream prefers stable releases over prereleases#6
Merged
Conversation
The tag selection used 'git tag --sort=-v:refname | head -1', which ranks v2.8.0-alpha.2 ABOVE v2.8.0 (git version-sort treats the prerelease suffix as higher without versionsort.suffix config). This pinned the frontend to an alpha forever once that alpha was synced. Now prefer the newest STABLE release (no -alpha/-beta/-rc suffix), falling back to the newest non-alpha prerelease only when no stable exists. Never auto-sync -alpha.
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
git tag -l 'v*.*.*' --sort=-v:refname | head -1ranksv2.8.0-alpha.2abovev2.8.0(git version-sort treats the prerelease suffix as higher withoutversionsort.suffix). Once an alpha was synced, the scheduled job kept selecting it and never advanced to the stable release - the frontend was stuck on an alpha while v2.8.0 stable existed.Fix
Prefer newest stable (no
-suffix); fall back to newest non-alpha prerelease (beta/rc) only if no stable exists; never auto-sync-alpha.Verified locally
v2.8.0-alpha.2; NEW logic picksv2.8.0.(DOS frontend has been manually tagged onto v2.8.0 stable already; this prevents regression.)