Batched animation processing#10
Open
Hexnet111 wants to merge 8 commits into
Open
Conversation
Add external annotation to GenList:NullOrEmpty
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I added a setting that allows for what I call "batched animation processing". Basically what this setting does is allow the user to split the processing of pawns into groups. The default number is 3 batch groups, which means pawns will be split into 3 groups and will be processed that way instead of all at once. This ends up giving back a bit of performance to the player, however at the cost of some animation stability since it CAN miss some animations or cause the animations to look a bit choppy at higher batch group settings.
Overall though, I still think it's a fair idea to have this setting implemented in the mod, whether by how I did it or in some other way shape or form since it makes the mod a bit nicer performance wise.
I do have a before and after if that is needed:
Batched animation processing off:
Batched animation processing on:
This was tested with approximately 250 pawns, and with a batch groups set to 3. (With the camera zoom maxed out.)
Please feel free to edit any of the changes! Also, I apologize for not including any keys in the Korean language xml, I do not know any Korean.