Sync#51
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces sync to ensure information is up to date based on Volta, allow current club members to register accounts and more.
Also changes the flow quite drastically, now we complete the full Faroe flow immediately since the e-mail verification code lasts only 20 minutes which clashes with the way I designed it first, where the admin accepts which immediately triggers e-mail verification code, but user could of course only see it a day later.
Most of the lines of code are tests and the spec. This spec, which can be found in backend/docs/spec.md was used to precisely describe the behavior of the core signup and login flows.