Adding stubs, and their inclusion in the venv - #34
Conversation
…ficient independently" This reverts commit 236d6cd.
|
Note, |
jcfreeman2
left a comment
There was a problem hiding this comment.
I would propose we allow the installation of *.pyi files be handled automatically by the daq_add_python_bindings function, as is done in DUNE-DAQ/daq-cmake#172, rather than adding logic to CMakeLists.txt for this.
… for review by daq-cmake centrally
|
That is a good suggestion, thanks @jcfreeman2 |
|
Regarding commit e20ab57, here are the notes Errors are reported as When first registering the |
jcfreeman2
left a comment
There was a problem hiding this comment.
This all passes the eye test. Additionally:
- This builds as part of a test build (
MYPYFD_DEV_260723_A9) which uses the newest version of daq-cmake cut this morning, and all integration tests pass - i.e., "does no harm" - If you locally build it in a work area,
*.pyifiles are installed - They're not in the test build, but that's the fault of
daq-cmake(see new Issue DUNE-DAQ/daq-cmake#174 for more)
Description
Prepares the repository for static type checking with
mypy. Thepy.typedfile is required to indicate that the code is ready for type checking, as per the PEP561 standards.Type of change
Testing checklist
dbt-build --unittest)pytest -s minimal_system_quick_test.py)dunedaq_integtest_bundle.sh)python -m pytest)pre-commit run --all-files)Comments here on the testing
Further checks
dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)(Indicate issue here: # (issue))