Skip to content

JCF: on James Paul Turner's recommendation, generate pybind11-stubgen… #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcfreeman2 merged 2 commits into from
Jul 23, 2026
Merged

JCF: on James Paul Turner's recommendation, generate pybind11-stubgen… #172

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb22ded
JCF: on James Paul Turner's recommendation, generate pybind11-stubgen…
Jul 16, 2026
02ab173
JCF: PR #172: add Pawel's suggestion, and also fix typos in warning m…
Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions cmake/DAQ.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -910,8 +910,26 @@ function(daq_add_python_bindings)
message(FATAL_ERROR "ERROR: No source files found for python library: ${libname}.")
endif()

find_program(PYBIND11_STUBGEN pybind11-stubgen)

if(PYBIND11_STUBGEN)
execute_process(
COMMAND ${PYBIND11_STUBGEN} -o ${PROJECT_NAME}/python ${PROJECT_NAME}
RESULT_VARIABLE retval
ERROR_VARIABLE errmsg
)

if(retval)
message(WARNING
"pybind11-stubgen failed for ${PROJECT_NAME}.\n"
"${errmsg}\n"
"The Python bindings were built successfully, but pybind11-stubgen was unable to generate stubs.")
endif()
endif()

_daq_define_exportname()
install(TARGETS ${libname} EXPORT ${DAQ_PROJECT_EXPORTNAME} DESTINATION ${destdir})
install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/python/${PROJECT_NAME}/ DESTINATION ${destdir} OPTIONAL FILES_MATCHING PATTERN "*.pyi" PATTERN "py.typed")
set(DAQ_PROJECT_INSTALLS_TARGETS true PARENT_SCOPE)

endfunction()
Expand Down
Loading