Skip to content

JCF: bump tag in CMakeLists.txt to v3.3.1 - #173

Merged
jcfreeman2 merged 1 commit into
developfrom
johnfreeman/bump_tag
Jul 23, 2026
Merged

JCF: bump tag in CMakeLists.txt to v3.3.1#173
jcfreeman2 merged 1 commit into
developfrom
johnfreeman/bump_tag

Conversation

@jcfreeman2

Copy link
Copy Markdown
Contributor

Description

This bumps the tag referred to in CMakeLists.txt, so we can tag the develop branch and use a daq-cmake which incorporates PR #172 into the nightly.

If full description and testing details are included on a parent issue, please link to that here.
See issue # for details

Otherwise, please include a summary of the change and which issue is fixed (if any).
Include relevant motivation and context, including a target environment and dunedaq version if known.
Also list any dependencies that are required for this change.

Addresses issue #

Please also include instructions for how a reviewer can test your changes.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (dunedaq_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Comments here on the testing

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

@jcfreeman2
jcfreeman2 requested a review from andrewmogan July 23, 2026 14:40

@andrewmogan andrewmogan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jcfreeman2
jcfreeman2 merged commit 9729473 into develop Jul 23, 2026
5 of 6 checks passed
@jcfreeman2
jcfreeman2 deleted the johnfreeman/bump_tag branch July 23, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants