Skip to content

Added logic to the dunedaq_integtest_bundle.sh script to provide hints… - #329

Open
bieryAtFnal wants to merge 3 commits into
developfrom
kbiery/bundle_script_option_hints
Open

Added logic to the dunedaq_integtest_bundle.sh script to provide hints…#329
bieryAtFnal wants to merge 3 commits into
developfrom
kbiery/bundle_script_option_hints

Conversation

@bieryAtFnal

Copy link
Copy Markdown
Contributor

…to the user when no tests are left after filtering based on the command-line options.

Description

In recent discussions, it was mentioned that there are times that the daqsystemtest/dunedaq_integtest_bundle.sh script finds no integtests that match what the user requested based on the command-line options provided to the script, and it is not obvious why the bundle script doesn't run any tests.

In subsequent discussions of how to deal with this issue, one suggestion was to provide more information to the user about what had happened and suggest alternatives (as compared with adding logic to the script to guess what the user wanted).

This PR attempts to do that. It now provides suggested command-line options.

For example:

$ dunedaq_integtest_bundle.sh -k process

Integtests from the _daqsystemtest_ repo will be run...
...Looking for integtests...

*** No integtests were found that matched the specified command-line options.

*** Consider adding '-r drunc' to the option list to pick up the 'process_manager_test.py' test.

*** 'list_available_integtests.sh' will list all available tests.

Here are suggested instructions for testing this change:

DATE_PREFIX=`date '+%d%b'`
TIME_SUFFIX=`date '+%H%M'`

source /cvmfs/dunedaq.opensciencegrid.org/setup_dunedaq.sh
setup_dbt latest
dbt-create -n NFD_DEV_260729_A9 ${DATE_PREFIX}FDDevTest_${TIME_SUFFIX}
cd ${DATE_PREFIX}FDDevTest_${TIME_SUFFIX}/sourcecode

git clone https://github.com/DUNE-DAQ/daqsystemtest.git -b kbiery/bundle_script_option_hints

cd ..

. ./env.sh
dbt-build -j 12
dbt-workarea-env

echo ""
echo -e "\U1F535 \U2705 Various bundle script argument combinations that now provide hints... \U2705 \U1F535"
echo ""
echo ""

dunedaq_integtest_bundle.sh -k process

sleep 3

dunedaq_integtest_bundle.sh -r trigger -k dis

sleep 3

dunedaq_integtest_bundle.sh -r trigger -k b

Type of change

  • Optimization (non-breaking change that improves code/performance)

Testing checklist

  • Full set of integration tests pass (dunedaq_integtest_bundle.sh)

…s to the user when no tests are left after filtering based on the command-line options.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants