Skip to content

Rename cleanup member fields - #108

Draft
denizergonul wants to merge 1 commit into
developfrom
dte/refactor_cleanup_config
Draft

Rename cleanup member fields#108
denizergonul wants to merge 1 commit into
developfrom
dte/refactor_cleanup_config

Conversation

@denizergonul

Copy link
Copy Markdown
Contributor

Description

In DefaultRequestHandlerModel:
m_pop_limit_pct is renamed as m_cleanup_min_occupancy_ratio.
m_pop_size_pct is renamed as m_cleanup_ratio.
m_pop_limit_size is renamed as m_cleanup_min_occupancy.

Let me know if you approve these name changes so I move on with the dependencies.

Obvious dependencies: appmodel daqsystemtest ehn1-daqconfigs

Not-very-obvious dependencies:

  • lbrulibs used in python/lbrulibs/app_confgen.py which looks very old and outdated.
  • dpdklibs used in python/dpdklibs/reader_confgen.py which looks very old and outdated.
  • dfmodules used in test/config/hdf5write_test_hwmap.data.xml which looks current.
  • dunedaq_conf_reader used in src/dunedaq_conf_reader/test/test-config.data.xml and src/dunedaq_conf_reader/test/test-config.data.json which look current.

So, dfmodules and dunedaq_conf_reader are also dependencies; lbrulibs and dpdklibsare not. Let me know if you disagree.

Addresses issue #10

Type of change

  • Optimization (non-breaking change that improves code/performance)

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas

@denizergonul denizergonul self-assigned this Oct 22, 2025
@denizergonul denizergonul linked an issue Oct 22, 2025 that may be closed by this pull request
@jcfreeman2

Copy link
Copy Markdown
Contributor

It looks like the code on this branch may need to be updated? The single-repo CI workflow that was triggered by the opening of this PR failed:

/__w/datahandlinglibs/datahandlinglibs/dev-a9/sourcecode/datahandlinglibs/include/datahandlinglibs/models/detail/DefaultRequestHandlerModel.hxx:15:46: error: 'const class dunedaq::appmodel::RequestHandler' has no member named 'get_cleanup_min_occupancy_ratio'
   15 |   m_cleanup_min_occupancy_ratio = reqh_conf->get_cleanup_min_occupancy_ratio();

@denizergonul
denizergonul marked this pull request as draft January 14, 2026 14:27
@denizergonul

Copy link
Copy Markdown
Contributor Author

It looks like the code on this branch may need to be updated? The single-repo CI workflow that was triggered by the opening of this PR failed:

/__w/datahandlinglibs/datahandlinglibs/dev-a9/sourcecode/datahandlinglibs/include/datahandlinglibs/models/detail/DefaultRequestHandlerModel.hxx:15:46: error: 'const class dunedaq::appmodel::RequestHandler' has no member named 'get_cleanup_min_occupancy_ratio'
   15 |   m_cleanup_min_occupancy_ratio = reqh_conf->get_cleanup_min_occupancy_ratio();

Hi,
The PR is incomplete, actually. (Maybe now that I converted it into Draft it makes more sense.)
I wanted to check first if the new names that I'm suggesting are okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor cleanup configuration

3 participants