-
Notifications
You must be signed in to change notification settings - Fork 5
Fix integ test #933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix integ test #933
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,6 +32,9 @@ | |
| "Worker with pid \\d+ was terminated due to signal", | ||
| "Connection '.*' not found on the application registry", | ||
| ], | ||
| "SSH_SHELL_process_manager": [ | ||
| "was terminated unexpectedly through the remote pid by a SIGKILL", | ||
| ], | ||
| "connectivity-service": [ | ||
| "errorlog: -", | ||
| ], | ||
|
|
@@ -345,7 +348,9 @@ def test_restart_mlt_logs(run_dunerc) -> None: | |
|
|
||
| require_pattern_match( | ||
| restart_text, | ||
| re.compile(r"Process 'mlt'.*?process exited\s+with exit code 0", re.DOTALL), | ||
| re.compile( | ||
| r"Process 'mlt' \(.*?\) was terminated by the process manager through the remote pid\. Reported exit code: 0\.", re.DOTALL | ||
| ), | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My only concern is this line, I'm not sure we've consistently got things so that the remote pid is always retrieved successfully for a clean exit. Although this is strictly better as it's more up to date so would support merging this
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks Aurash, thats useful information to know! My two cents:
|
||
| error_message="Did not find the mlt exit-code log line after graceful termination.", | ||
| ) | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flagging this up for the review of DUNE-DAQ/integrationtest#158