Skip to content

Failures of integration tests with disabled connectivity services #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
PawelPlesniak wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Failures of integration tests with disabled connectivity services #970

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/drunc/unified_shell/shell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,9 @@ def unified_shell(
f"{process_manager_address}[/green]"
)
ctx.obj.reset(address_pm=process_manager_address)
ctx.obj.log.critical(
f"Investigating the session DAL's connectivity service: {session_dal.connectivity_service}"
)

# Run a simple command (describe) to check the connection with the process manager
try:
Expand Down Expand Up @@ -478,7 +481,10 @@ def cleanup():
# all the processes. During this time the non-terminated processes will continue
# to publish to the connectivity service, and this stale information needs to be
# cleaned up by retracting the session (again).
if session_dal.connectivity_service.host != "localhost":
if (
session_dal.connectivity_service
and session_dal.connectivity_service.getattr("host") != "localhost"
):
connectivity_service_address: str = (
f"{session_dal.connectivity_service.host}:"
f"{session_dal.connectivity_service.service.port}"
Expand Down
Loading