Unify ps implementation to fix the PM integ test

[emmuhamm]

Description

Fixes issue #979

Fix the PM integ test

Fix PM integ test script itself

The PS command recently got updated to not print any table at all in case there is no process up and running (eg. before boot). This change was not reflected in the integ test. This is now rectified.

Unified the PS implementation

#912, among other things, unified a lot of the PM commands for them to be ported over to the US (see point 5). During this migration, the ps command was left behind ;-;.

On its own this would have been fine, but as luck would have it there are two different implementations. The PM implementation had a working --width and --user code, but the US did not. Hence, the integ tests (and any unified shell) will complain if doing eg. ps -w 140 or ps -u emmuhamm.

This is now rectified by unifying the two implementations, exactly the same way as was done in #912

Type of change

• Bug fix

Suggested manual testing checklist

pytest -s src/drunc/integtest/controller_test.py --integtest-verbosity 5. This should pass.

Developer checklist

Prior to marking this as "Ready for Review"

Tests ran on: np04-srv-028 from release 21 June nightly.

• Unit tests (pytest --marker) passed
  • With relevant marker
• Integration tests passed
  • Only daqsystemtest_integtest_bundle.sh -k minimal_system_quick_test.py
• Drunc integration tests pass (./scripts/drunc_integtest_bundle.sh)

Final checklist prior to marking this as "Ready for Review"

• Code is clearly commented.
• A suitable reviewer has been chosen from this list.

Reviewer checklist

• This branch has been rebased with develop prior to testing.
• Suggested manual tests show changes.
• CI workflows fails documented (if present)
• Integration tests passed (on either np0x or IC HEP clusters)
  • Use the following guidelines to determine which of the integration tests you need to run
    • You do not need to run any integration tests if
      • Code changes are not associated with src/
      • PR changes only affect docstrings
      • In this case, be sure to validate any suggested manual testing.
    • Run only the minimum integration test as daqsystemtest_integtest_bundle.sh -k minimal_system_quick_test.py if
      • PR changes only affect a few log entries
      • PR changes are small, and do not have a large impact on the workflow (use carefully)
    • Otherwise run the full integration test bundle as daqsystemtest_integtest_bundle.sh
  • What to do if the integration tests fail?
    • Only concern yourself if failures related to drunc are in the log files
    • If non-drunc failure appears:
      • Validate failure in fresh working area
      • Contact Pawel if unsure
• If you have ran the full integration test bundle, leave a comment on the PR stating
  • Which host the integration tests have ran on
  • [Optional] A copy of the test summary
• Drunc integration tests pass (scripts/drunc_integtest_bundle.sh)

Once the above boxes are checked, the PR(s) can be merged following the steps below.

Prior to merging

Choose one of the following an complete all substeps

• Changes only affect the Run Control, are in a single repository, and do not affect the end user.
  • Changes are documented in docstrings and code comments
  • Wiki has been updated if architectural or endpoint changes
• Otherwise
  • Workflow changes demonstrated in the Change Log (if necessary)
  • Wiki has been updated (if necessary)
  • #dunedaq-integration Slack channel notified (see below)

Once completed, the reviewer can merge the PR.

Notification message for a Slack channel

Note - this should be to #dunedaq-integration for general workflow that isn't during a release candidate period, and to #daq-release-prep otherwise.

For an single merge that changes the user workflow

The CCM WG has an isolated PR ready to merge that affects user workflows. The PR is:

_URL_

I will leave time for any comments, otherwise will merge these at the end of the work day _Insert your time zone_.

For co-ordinated merge

The CCM WG has a set of co-ordinated merges ready to merge. The PRs are:

_URL_

_URL_


I will leave time for any comments, otherwise will merge these at the end of the day.

[PawelPlesniak]

One small typo, otherwise changes look good. Running the process manager test as

pytest src/drunc/integtest/process_manager_test.py

passed. MSQT also passed, approved. Nice work!