Skip to content

Make return code optional - #86

Merged
Aurashk merged 2 commits into
developfrom
emmuhamm/return-code-optional
Jun 1, 2026
Merged

Make return code optional#86
Aurashk merged 2 commits into
developfrom
emmuhamm/return-code-optional

Conversation

@emmuhamm

Copy link
Copy Markdown
Member

Description

Fixes #15

See above

Makes return code optional in process manager

Corresponding change in drunc is

Type of change

  • Optimization (non-breaking, back-end change that speeds up the code)

Key checklist

  • All tests pass (eg. python -m pytest)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

@emmuhamm emmuhamm self-assigned this May 29, 2026
@emmuhamm
emmuhamm requested review from Aurashk and PawelPlesniak May 29, 2026 11:10
@Aurashk

Aurashk commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Optional return code is sensible! I ran msqt on hep with this branch of drunc and it passed

@Aurashk
Aurashk merged commit d10c2e7 into develop Jun 1, 2026
1 check passed
@Aurashk
Aurashk deleted the emmuhamm/return-code-optional branch June 1, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Return code should be optional

3 participants