Pawel plesniak/incomplete stateful command transition - #87
Open
PawelPlesniak wants to merge 4 commits into
Open
Conversation
emmuhamm
reviewed
Jul 21, 2026
emmuhamm
left a comment
Member
There was a problem hiding this comment.
Just to quickly comment that I had a look over this PR on its own and this looks good to me. The changes makes sense and I don't have much to say about this.
I will review this PR again in conjunction with the big boi and will approve this if I see that this set of changes does what we want it to do there.
emmuhamm
force-pushed
the
PawelPlesniak/IncompleteStatefulCommandTransition
branch
from
July 21, 2026 15:10
308fca0 to
4b37fb4
Compare
Member
|
I've finished the first round of reviews for the associated PR DUNE-DAQ/drunc#868. Given that theres a few comments there, theres a very small but nonzero possibility some of the functionality / names might need changing. Therefore, although I think this PR LGTM, I'll prefer leaving this open to allow for the flexibility of changing these endpoints if desired |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #89
Adds a new endpoint
log_on_serverwhich allows the user to publish messages in the relevant log files.Type of change
Key checklist
python -m pytest)pre-commit run --all-files)Further checks
(Indicate issue here: # (issue))