Skip to content

Pawel plesniak/incomplete stateful command transition - #87

Open
PawelPlesniak wants to merge 4 commits into
developfrom
PawelPlesniak/IncompleteStatefulCommandTransition
Open

Pawel plesniak/incomplete stateful command transition#87
PawelPlesniak wants to merge 4 commits into
developfrom
PawelPlesniak/IncompleteStatefulCommandTransition

Conversation

@PawelPlesniak

@PawelPlesniak PawelPlesniak commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes #89

Adds a new endpoint log_on_server which allows the user to publish messages in the relevant log files.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

@emmuhamm emmuhamm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to quickly comment that I had a look over this PR on its own and this looks good to me. The changes makes sense and I don't have much to say about this.

I will review this PR again in conjunction with the big boi and will approve this if I see that this set of changes does what we want it to do there.

@emmuhamm
emmuhamm force-pushed the PawelPlesniak/IncompleteStatefulCommandTransition branch from 308fca0 to 4b37fb4 Compare July 21, 2026 15:10
@emmuhamm

Copy link
Copy Markdown
Member

I've finished the first round of reviews for the associated PR DUNE-DAQ/drunc#868. Given that theres a few comments there, theres a very small but nonzero possibility some of the functionality / names might need changing.

Therefore, although I think this PR LGTM, I'll prefer leaving this open to allow for the flexibility of changing these endpoints if desired

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Extend the process manager and controller code to be able to log on the relevant server

3 participants