Adding gRPC stubs - #90
Merged
Merged
Conversation
added 2 commits
July 28, 2026 17:28
25 tasks
Contributor
Author
|
MSQT and |
emmuhamm
approved these changes
Jul 31, 2026
emmuhamm
left a comment
Member
There was a problem hiding this comment.
LGTM 👍
To summarise, the main change in this PR is the line compiled_extensions = ["_pb2.py", "_pb2.pyi", "_pb2_grpc.py", "_pb2_grpc.pyi"] in the generate_protos.py, and any relevant changes in generate_protos.
The other changes in the .py files looks like formatting, and the stuffs in the pyproject.toml also is mostly formatting and updating. Stuff in src/druncschema is also the generated files, so I didn't take a look at them.
Feel free to merge whenever :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Helps with issue DUNE-DAQ/drunc#848
TLDR - while the message schema themselves had stubs, the gRPC service objects themselves did not. This PR allows for the stub files to also be generated.
Type of change
Key checklist
python -m pytest)pre-commit run --all-files)Further checks
(Indicate issue here: # (issue))