Skip to content

Adding gRPC stubs - #90

Merged
emmuhamm merged 3 commits into
developfrom
PawelPlesniak/Mypy
Jul 31, 2026
Merged

Adding gRPC stubs#90
emmuhamm merged 3 commits into
developfrom
PawelPlesniak/Mypy

Conversation

@PawelPlesniak

@PawelPlesniak PawelPlesniak commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Description

Helps with issue DUNE-DAQ/drunc#848

TLDR - while the message schema themselves had stubs, the gRPC service objects themselves did not. This PR allows for the stub files to also be generated.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

@PawelPlesniak
PawelPlesniak requested a review from emmuhamm July 29, 2026 11:51
@PawelPlesniak

Copy link
Copy Markdown
Contributor Author

MSQT and drunc integration tests passed on np04-srv-028 using NFD_DEV_260729_A9.

@emmuhamm emmuhamm assigned emmuhamm and PawelPlesniak and unassigned emmuhamm Jul 31, 2026

@emmuhamm emmuhamm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

To summarise, the main change in this PR is the line compiled_extensions = ["_pb2.py", "_pb2.pyi", "_pb2_grpc.py", "_pb2_grpc.pyi"] in the generate_protos.py, and any relevant changes in generate_protos.

The other changes in the .py files looks like formatting, and the stuffs in the pyproject.toml also is mostly formatting and updating. Stuff in src/druncschema is also the generated files, so I didn't take a look at them.

Feel free to merge whenever :D

@emmuhamm
emmuhamm merged commit a1fe630 into develop Jul 31, 2026
@emmuhamm
emmuhamm deleted the PawelPlesniak/Mypy branch July 31, 2026 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants