Skip to content

Johnfreeman/file formats refactor - #139

Open
jcfreeman2 wants to merge 4 commits into
developfrom
johnfreeman/file_formats_refactor
Open

Johnfreeman/file formats refactor#139
jcfreeman2 wants to merge 4 commits into
developfrom
johnfreeman/file_formats_refactor

Conversation

@jcfreeman2

Copy link
Copy Markdown
Contributor

Description

This draft PR is needed for the primary draft PR, DUNE-DAQ/dfmodules#497, to build

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (dunedaq_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Comments here on the testing

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

Your Name added 4 commits June 30, 2026 12:48
…n the caller, which can query timeslice_already_exists
…y of the session object, pass it as a reference and not a pointer
…o satisfy dfmodules' FileHandleConcept's new requirement

@eflumerf eflumerf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, probably won't have a chance to run through the integration tests until August, though

@jcfreeman2
jcfreeman2 marked this pull request as ready for review August 5, 2026 18:55
@jcfreeman2

Copy link
Copy Markdown
Contributor Author

This is to be merged in concert with the feature branches of the same name in appmodel and dfmodules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants