Updated the logfile exclusions defined in log_file_checks::logs_are_error_free()… - #163
Merged
bieryAtFnal merged 2 commits intoJul 29, 2026
Merged
Conversation
…rror_free() so that when drunc debug messages are enabled, we don't complain about irrelevant messages.
|
Thank you Kurt, I ran the aforementioned tests and can confirm the expected outcomes of failure with verbosity 6 without this branch and passing with this branch. |
PawelPlesniak
approved these changes
Jul 29, 2026
Contributor
Author
|
Thanks for the review, Pawel. Merging now... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… so that when
druncdebug messages are enabled, we don't complain about irrelevant messages.Description
I noticed that when I enabled a verbosity level of 6 (six) in our regression tests with a recent nightly build, there were new messages in the
druncdebug output that caused thelog_file_checksin theintegrationtestinfrastructure to think that there were problems with the test results, even though there weren't any problems with the test.The changes in this PR update the centrally-defined exclusions (in the
log_file_checks.pyfile) so that passing integtests are not erroneous reported as failing.Here are suggested instructions for testing these changes:
Type of change
Testing checklist
dunedaq_integtest_bundle.sh)