Skip to content

Updated the logfile exclusions defined in log_file_checks::logs_are_error_free()… - #163

Merged
bieryAtFnal merged 2 commits into
developfrom
kbiery/updated_drunc_debug_logfile_exclusions
Jul 29, 2026
Merged

Updated the logfile exclusions defined in log_file_checks::logs_are_error_free()…#163
bieryAtFnal merged 2 commits into
developfrom
kbiery/updated_drunc_debug_logfile_exclusions

Conversation

@bieryAtFnal

@bieryAtFnal bieryAtFnal commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

… so that when drunc debug messages are enabled, we don't complain about irrelevant messages.

Description

I noticed that when I enabled a verbosity level of 6 (six) in our regression tests with a recent nightly build, there were new messages in the drunc debug output that caused the log_file_checks in the integrationtest infrastructure to think that there were problems with the test results, even though there weren't any problems with the test.

The changes in this PR update the centrally-defined exclusions (in the log_file_checks.py file) so that passing integtests are not erroneous reported as failing.

Here are suggested instructions for testing these changes:

DATE_PREFIX=`date '+%d%b'`
TIME_SUFFIX=`date '+%H%M'`

source /cvmfs/dunedaq.opensciencegrid.org/setup_dunedaq.sh
setup_dbt latest
dbt-create -n NFD_DEV_260727_A9 ${DATE_PREFIX}FDDevTest_${TIME_SUFFIX}
cd ${DATE_PREFIX}FDDevTest_${TIME_SUFFIX}/sourcecode

git clone https://github.com/DUNE-DAQ/daqsystemtest.git -b develop

cd ..

cd pythoncode
git clone https://github.com/DUNE-DAQ/integrationtest.git -b develop
cd ..

. ./env.sh
dbt-build -j 12
dbt-workarea-env

dunedaq_integtest_bundle.sh -k small --verb 5

echo ""
echo -e "\U1F535 \U2705 Note that the SFQT integtest ran fine with verbosity level of 5. \U2705 \U1F535"
echo ""
echo ""
sleep 3

dunedaq_integtest_bundle.sh -k small --verb 6

echo ""
echo -e "\U1F535 \U2705 Note that the SFQT integtest reported problems with verbosity level of 6. \U2705 \U1F535"
echo -e "\U1F535 \U2705 (These are not real problem; they are a by-product of drunc debug mode.) \U2705 \U1F535"
echo ""
echo ""
sleep 3

cd pythoncode/integrationtest
git checkout kbiery/updated_drunc_debug_logfile_exclusions
pip install .
cd ../../

dunedaq_integtest_bundle.sh -k small --verb 6

echo ""
echo -e "\U1F535 \U2705 Note that the SFQT integtest now runs cleanly even with a verbosity level of 6. \U2705 \U1F535"
echo ""
echo ""
sleep 3

dunedaq_integtest_bundle.sh -k example --verb 6

echo ""
echo -e "\U1F535 \U2705 Note that the example_system_test also runs cleanly with a verbosity level of 6. \U2705 \U1F535"
echo ""
echo ""

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing checklist

  • Full set of integration tests pass (dunedaq_integtest_bundle.sh)

Kurt Biery and others added 2 commits July 27, 2026 20:12
…rror_free() so that when drunc debug messages are enabled, we don't complain about irrelevant messages.
@PawelPlesniak

Copy link
Copy Markdown

Thank you Kurt, I ran the aforementioned tests and can confirm the expected outcomes of failure with verbosity 6 without this branch and passing with this branch.

@bieryAtFnal

Copy link
Copy Markdown
Contributor Author

Thanks for the review, Pawel. Merging now...

@bieryAtFnal
bieryAtFnal merged commit 5c59c36 into develop Jul 29, 2026
@bieryAtFnal
bieryAtFnal deleted the kbiery/updated_drunc_debug_logfile_exclusions branch July 29, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants