Modified log_file_checks::logs_are_error_free to make use of a local copy of the exlcuded_substring_map …

[bieryAtFnal]

… so that we don't leak local mods to that map back into the calling code.

Description

To test this change, run the listrev_test with dunedaq_integtest_bundle.sh --verb 4 -r listrev and note that the console output that talks about ignored problems in the drunc console logfile reports an increasing number of ignored phrases.

With this branch, the number of ignored phrase should remain constant.

Type of change

• Bug fix (non-breaking change which fixes an issue)

Testing checklist

• Full set of integration tests pass (dunedaq_integtest_bundle.sh)

[jcfreeman2]

Looks good to me. If I use the develop branch of integrationtest in a work area and run listrev_test, these lines appear progressively in the output:

Note: problems found in 50 lines in /tmp/pytest-of-jcfree/pytest-99/run0/log_jcfree_drunc_console_output.txt were ignored based on 6 phrase(s).
but then
Note: problems found in 48 lines in /tmp/pytest-of-jcfree/pytest-99/run1/log_jcfree_drunc_console_output.txt were ignored based on 12 phrase(s).
and finally at the bottom,
Note: problems found in 48 lines in /tmp/pytest-of-jcfree/pytest-99/run6/log_jcfree_drunc_console_output.txt were ignored based on 42 phrase(s).
...i.e., the number of phrase(s) is increasing by 6 each iteration.

On the other hand, if I use this feature branch of integrationtest, the only output I see is of the form
Note: problems found in N lines in /tmp/pytest-of-jcfree/pytest-101/run3/log_jcfree_drunc_console_output.txt were ignored based on 6 phrase(s).
...where N is a variable I'm substituting in for the reader.

[jcfreeman2]

Looks good, see my comment from a moment ago.