Skip to content

Fixed excluded substring patterns in log_file_checks.py that have backslashes… - #165

Merged
jcfreeman2 merged 3 commits into
developfrom
kbiery/esc_seq_wrn_fix
Aug 3, 2026
Merged

Fixed excluded substring patterns in log_file_checks.py that have backslashes…#165
jcfreeman2 merged 3 commits into
developfrom
kbiery/esc_seq_wrn_fix

Conversation

@bieryAtFnal

Copy link
Copy Markdown
Contributor

… to be raw strings

Description

Earlier today, Michal reported that he noticed messages like the following when running regression tests like minimal_system_quick_test with the latest nightly build:

=============================== warnings summary ===============================
.venv/lib/python3.12/site-packages/integrationtest/log_file_checks.py:111
  /home/nfs/biery/dunedaq/03AugFDDevTest730_1552/.venv/lib/python3.12/site-packages/integrationtest/log_file_checks.py:111: SyntaxWarning: invalid escape sequence '\s'
    ["LogLevel=error", "key:\s\"DUNEDAQ_ERS_"]

.venv/lib/python3.12/site-packages/integrationtest/log_file_checks.py:114
  /home/nfs/biery/dunedaq/03AugFDDevTest730_1552/.venv/lib/python3.12/site-packages/integrationtest/log_file_checks.py:114: SyntaxWarning: invalid escape sequence '\s'
    ["LogLevel=error", "key:\s\"DUNEDAQ_ERS_", "DUNEDAQ_ERS_.*erstrace", "export DUNEDAQ_ERS_",

.venv/lib/python3.12/site-packages/integrationtest/log_file_checks.py:115
  /home/nfs/biery/dunedaq/03AugFDDevTest730_1552/.venv/lib/python3.12/site-packages/integrationtest/log_file_checks.py:115: SyntaxWarning: invalid escape sequence '\['
    "NewConnectionError.* Failed to establish a new connection: \[Errno 111\] Connection refused"]

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
======================== 3 passed, 3 warnings in 59.57s ========================

It seems that this problem can only be seen when the first integtest is run after a new local software area is created. That's pretty weird, but I believe that the problem originated when I added extra "excluded substrings" to log_file_checks.py.

This PR has improvements in the way that the excluded substrings are declared, and I'm hopeful that these changes will eliminate the messages that Michal reported.

I've confirmed that a sampling of regression tests continues to run normally with these changes.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing checklist

  • Full set of integration tests pass (dunedaq_integtest_bundle.sh)

@jcfreeman2

Copy link
Copy Markdown
Contributor

Approved. In two separate terminals, I set up two separate work areas. In the first one, I built the develop branch of integrationtest and got ======================== 4 passed, 3 warnings in 57.82s ======================== for the MSQT. In the other, I built this feature branch, and just got ============================== 4 passed ✅ in 57.71s ==============================.

@jcfreeman2
jcfreeman2 merged commit 6e34e12 into develop Aug 3, 2026
1 check passed
@jcfreeman2
jcfreeman2 deleted the kbiery/esc_seq_wrn_fix branch August 3, 2026 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants