Skip to content

Defer any access to DAL until conf transition. Just take a copy of th… - #126

Draft
gcrone wants to merge 1 commit into
developfrom
gcrone/dal_at_config
Draft

Defer any access to DAL until conf transition. Just take a copy of th…#126
gcrone wants to merge 1 commit into
developfrom
gcrone/dal_at_config

Conversation

@gcrone

@gcrone gcrone commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Description

Defer any access to DAL until conf transition. Just take a copy of the config manager pointer at init. This allows for the configuration to be reloaded before conf which would invalidate any dal object pointers.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (dunedaq_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Comments here on the testing

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants