Kalman test - #219
Open
kyjung123 wants to merge 17 commits into
Open
Conversation
Include start point
fix bug
Contributor
|
@kyjung123, these look interesting but there are now conflicts that need to be resolved. Can you fix them and then we can approve this PR |
Member
Author
|
@jdkio Sorry for the late response, but I’ve resolved the conflicts. Please take a look when you have a chance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I edited it the Kalman filter, most of contents are here, #217 (https://indico.fnal.gov/event/69145/contributions/314021/attachments/187103/257951/TMS_Kalman_0415.pdf)
This Kalman filter didn't include the magnetic field. So the variables, ..._plus or _minus, are used only in chi2 calculation and KalmanNode is just defined as plus charge assumption, which didn't impact on the kalman fitting.
Note> also edited the neutrino vertex units to mm in TMS_Event.cpp to get output from InteractionLArFiducial function.