Use position writer for truth end positions - #274
Merged
Conversation
toi42
approved these changes
Jul 21, 2026
SFBayLaser
added a commit
that referenced
this pull request
Aug 4, 2026
(cherry picked from commit a9bddb8) Cherry-picked from main (PR #274, jdkio) after noticing origin/main had moved during Phase III work. Small, isolated fix -- setMomentum() was used where setPosition() belongs for RecoTrackPrimaryParticleTruePositionEnd/ RecoTrackSecondaryParticleTruePositionEnd. Doesn't overlap with anything Phase III touched in this file; cherry-picked rather than a full rebase to avoid rewriting already-pushed history.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small bug fix where the momentum function was used for position data. The code is almost isomorphic though. The position code makes sure the time channel is the time within spill.