Use transverse width for X-bar containment - #289
Open
jdkio wants to merge 1 commit into
Open
Conversation
toi42
approved these changes
Jul 29, 2026
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


The X bar used the wrong transverse width. This caused the hough transform to get very confused. It would add a bunch of extra hits to the candidate. Then it was up to DB scan to fix the issue by making sure what it found was contiguous.
Note that this is only a problem for pileup or busy events. A single muon event should process about the same. But this would lead to different behavior in X and Y views.
See these diagnostic plots using branch
jdkio/266_hough_attempt_diagnostics. In them, we see all hits would be hough seeds (orange circles), rather than only the ones along the line. This would also lead to bad line candidates, which is why the red line is not pointing along the eventual DB scan's hits. The DB scan hits then fix the issue slightly. Those hits are then removed for the next attempt, but I'm not sure that helps much. The Y view wasn't affected, which is how we were able to find the issue.Before
After