Skip to content

Use transverse width for X-bar containment - #289

Open
jdkio wants to merge 1 commit into
mainfrom
jdkio/266_xbar_transverse_width
Open

Use transverse width for X-bar containment#289
jdkio wants to merge 1 commit into
mainfrom
jdkio/266_xbar_transverse_width

Conversation

@jdkio

@jdkio jdkio commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

The X bar used the wrong transverse width. This caused the hough transform to get very confused. It would add a bunch of extra hits to the candidate. Then it was up to DB scan to fix the issue by making sure what it found was contiguous.

Note that this is only a problem for pileup or busy events. A single muon event should process about the same. But this would lead to different behavior in X and Y views.

See these diagnostic plots using branch jdkio/266_hough_attempt_diagnostics. In them, we see all hits would be hough seeds (orange circles), rather than only the ones along the line. This would also lead to bad line candidates, which is why the red line is not pointing along the eventual DB scan's hits. The DB scan hits then fix the issue slightly. Those hits are then removed for the next attempt, but I'm not sure that helps much. The Y view wasn't affected, which is how we were able to find the issue.

Before

image

After

image

@jdkio
jdkio requested a review from toi42 July 28, 2026 21:38
@jdkio jdkio added the bug Something isn't working label Jul 28, 2026
@toi42

toi42 commented Jul 29, 2026

Copy link
Copy Markdown
Member

Actually, this pull seems to somehow drop efficiency. While this is being investigated, we should hold off on merging this in.

(EDIT: this is also on a single neutrino file, so something has gone wrong deeper than this fix)

On this pull
muon_ke_tms_enter

Main with the same settings

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants