Skip to content

[spack mpd] Fix more assert on assignment causing parenthesis warning. Use CMake variables that exist to define test environment vars. #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gartung wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[spack mpd] Fix more assert on assignment causing parenthesis warning. Use CMake variables that exist to define test environment vars. #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52eab9b
Fix more assert on assignment causing parenthesis warning
gartung Jul 20, 2026
a98b4ab
Use CMake variables that exist to define test environment vars
gartung Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dunedataprep/DataPrep/Service/test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ include(CetTest)
cet_enable_asserts()

cet_transitive_paths(FHICL_DIR BINARY IN_TREE)
cet_test_env_prepend(FHICL_FILE_PATH "." ${TRANSITIVE_PATHS_WITH_FHICL_DIR} ${PROJECT_BINARY_DIR}/fcl ${dunecalib_BINARY_DIR}/fcl ${dunesim_BINARY_DIR}/fcl ${dunesw_BINARY_DIR}/fcl ${duneopdet_BINARY_DIR}/fcl ${duneprototypes_BINARY_DIR}/fcl)
cet_test_env_prepend(FHICL_FILE_PATH "." ${TRANSITIVE_PATHS_WITH_FHICL_DIR} ${PROJECT_BINARY_DIR}/fcl ${PROJECT_BINARY_DIR}/../dunecalib/fcl ${PROJECT_BINARY_DIR}/../dunesim/fcl ${PROJECT_BINARY_DIR}/../dunesw/fcl ${PROJECT_BINARY_DIR}/../duneopdet/fcl ${PROJECT_BINARY_DIR}/../duneprototypes/fcl)
cet_transitive_paths(LIBRARY_DIR BINARY IN_TREE)
cet_test_env_prepend(CET_PLUGIN_PATH ${TRANSITIVE_PATHS_WITH_LIBRARY_DIR})
cet_test_env_prepend(FW_SEARCH_APTH ${PROJECT_BINARY_DIR}/fcl)
cet_test_env_prepend(CET_PLUGIN_PATH ${TRANSITIVE_PATHS_WITH_LIBRARY_DIR} ${PROJECT_BINARY_DIR}/../dunesim/lib)
cet_test_env_prepend(FW_SEARCH_PATH ${PROJECT_BINARY_DIR}/fcl ${PROJECT_BINARY_DIR}/../dunecore/gdml)

cet_test(test_ConfigurableAdcChannelDataCopyService
SOURCE
Expand Down
6 changes: 3 additions & 3 deletions dunedataprep/DataPrep/Tool/test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@
include(CetTest)

cet_transitive_paths(FHICL_DIR BINARY IN_TREE)
cet_test_env_prepend(FHICL_FILE_PATH "." ${TRANSITIVE_PATHS_WITH_FHICL_DIR} ${PROJECT_BINARY_DIR}/fcl ${dunecalib_BINARY_DIR}/fcl ${dunesim_BINARY_DIR}/fcl ${duneopdet_BINARY_DIR}/fcl ${dunedataprep_BINARY_DIR}/fcl ${dunesw_BINARY_DIR}/fcl ${duneprototypes_BINARY_DIR}/fcl)
cet_test_env_prepend(FHICL_FILE_PATH "." ${TRANSITIVE_PATHS_WITH_FHICL_DIR} ${PROJECT_BINARY_DIR}/fcl ${PROJECT_BINARY_DIR}/../dunecalib/fcl ${PROJECT_BINARY_DIR}/../dunesim/fcl ${PROJECT_BINARY_DIR}/../duneopdet/fcl ${PROJECT_BINARY_DIR}/../dunedataprep/fcl ${PROJECT_BINARY_DIR}/../dunesw/fcl ${PROJECT_BINARY_DIR}/../duneprototypes/fcl)
cet_transitive_paths(LIBRARY_DIR BINARY IN_TREE)
cet_test_env_prepend(CET_PLUGIN_PATH ${TRANSITIVE_PATHS_WITH_LIBRARY_DIR})
cet_test_env_prepend(CET_PLUGIN_PATH ${TRANSITIVE_PATHS_WITH_LIBRARY_DIR} ${PROJECT_BINARY_DIR}/../dunesim/lib ${PROJECT_BINARY_DIR}/../duneprototypes/lib)
cet_transitive_paths(GDML_DIR BINARY IN_TREE)
cet_test_env_prepend(FW_SEARCH_PATH ${TRANSITIVE_PATHS_WITH_GDML_DIR} ${PROJECT_BINARY_DIR}/gdml ${dunecore_BINARY_DIR}/gdml)
cet_test_env_prepend(FW_SEARCH_PATH ${TRANSITIVE_PATHS_WITH_GDML_DIR} ${PROJECT_BINARY_DIR}/gdml ${PROJECT_BINARY_DIR}/../dunecore/gdml)

cet_test(test_StandardAdcChannelStringTool
SOURCE
Expand Down
2 changes: 1 addition & 1 deletion dunedataprep/DataPrep/Tool/test/test_AdcKeepAllSignalFinder.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ int test_AdcKeepAllSignalFinder(bool useExistingFcl =false) {
data.samples[30] = 150.0;
assert( data.signal.size() == 0 );
assert( data.rois.size() == 0 );
assert( data.samples[30] = 150 );
assert( data.samples[30] == 150 );

cout << myname << line << endl;
cout << myname << "Running tool." << endl;
Expand Down
2 changes: 1 addition & 1 deletion dunedataprep/DataPrep/Tool/test/test_AdcNoiseSignalFinder.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ int test_AdcNoiseSignalFinder(bool useExistingFcl =false) {
data.samples[30] = 150.0;
assert( data.signal.size() == 0 );
assert( data.rois.size() == 0 );
assert( data.samples[30] = 150 );
assert( data.samples[30] == 150 );

cout << myname << line << endl;
cout << myname << "Running tool." << endl;
Expand Down
2 changes: 1 addition & 1 deletion dunedataprep/DataPrep/Tool/test/test_AdcRegularSignalFinder.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ int test_AdcRegularSignalFinder(bool useExistingFcl =false) {
assert( data.signal.size() == 0 );
assert( data.rois.size() == 0 );
assert( data.samples.size() == nsam );
assert( data.samples[30] = 150 );
assert( data.samples[30] == 150 );

cout << myname << line << endl;
cout << myname << "Running tool." << endl;
Expand Down
2 changes: 1 addition & 1 deletion dunedataprep/DataPrep/Tool/test/test_AdcThresholdSignalFinder.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ int test_AdcThresholdSignalFinder(bool useExistingFcl =false) {
data.samples[30] = 150.0;
assert( data.signal.size() == 0 );
assert( data.rois.size() == 0 );
assert( data.samples[30] = 150 );
assert( data.samples[30] == 150 );

cout << myname << line << endl;
cout << myname << "Running tool." << endl;
Expand Down
2 changes: 1 addition & 1 deletion dunedataprep/DataPrep/Tool/test/test_VintageDeconvoluter.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ int test_VintageDeconvoluter(bool useExistingFcl =false) {
data.samples[30] = 150.0;
assert( data.signal.size() == 0 );
assert( data.rois.size() == 0 );
assert( data.samples[30] = 150 );
assert( data.samples[30] == 150 );
AdcChannelData data0 = data;
data0.signal = data.signal;
data0.rois = data.rois;
Expand Down
2 changes: 1 addition & 1 deletion dunedataprep/DataPrep/TpcTool/test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
include(CetTest)

cet_transitive_paths(FHICL_DIR BINARY IN_TREE)
cet_test_env_prepend(FHICL_FILE_PATH "." ${TRANSITIVE_PATHS_WITH_FHICL_DIR} ${PROJECT_BINARY_DIR}/fcl ${dunesim_BINARY_DIR}/fcl)
cet_test_env_prepend(FHICL_FILE_PATH "." ${TRANSITIVE_PATHS_WITH_FHICL_DIR} ${PROJECT_BINARY_DIR}/fcl ${PROJECT_BINARY_DIR}/../dunesim/fcl)
cet_transitive_paths(LIBRARY_DIR BINARY IN_TREE)
cet_test_env_prepend(CET_PLUGIN_PATH ${TRANSITIVE_PATHS_WITH_LIBRARY_DIR})

Expand Down
2 changes: 1 addition & 1 deletion dunedataprep/DataPrep/Utility/test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
include(CetTest)

cet_transitive_paths(FHICL_DIR BINARY IN_TREE)
cet_test_env_prepend(FHICL_FILE_PATH "." ${TRANSITIVE_PATHS_WITH_FHICL_DIR} ${dunesim_BINARY_DIR}/fcl)
cet_test_env_prepend(FHICL_FILE_PATH "." ${TRANSITIVE_PATHS_WITH_FHICL_DIR} ${PROJECT_BINARY_DIR}/../dunesim/fcl)
cet_transitive_paths(LIBRARY_DIR BINARY IN_TREE)
cet_test_env_prepend(CET_PLUGIN_PATH ${TRANSITIVE_PATHS_WITH_LIBRARY_DIR})

Expand Down