Skip to content

Fix search using remaing terms#193

Merged
Neraste merged 4 commits into
developfrom
fix/192-query
Jul 25, 2026
Merged

Fix search using remaing terms#193
Neraste merged 4 commits into
developfrom
fix/192-query

Conversation

@Neraste

@Neraste Neraste commented Jul 20, 2026

Copy link
Copy Markdown
Member

#181 introduced the possibility to search more than songs, and was a refactor of the search engine. The implementation prior the PR allowed to find the conjunction of remaining terms (i.e., without using the mini-language keywords), when the implementation after it finds the disjunction of these terms. This behavior was not tested.

This PR reestablishes the conjunction of remaining terms for all type of queries:

  • Songs;
  • Artists;
  • Song tags;
  • Works;
  • Playlist entries;
  • Player errors; and
  • Users.

@Neraste Neraste added this to the 1.10.0 milestone Jul 20, 2026
@Neraste Neraste self-assigned this Jul 20, 2026
@Neraste Neraste added the bug Something isn't working label Jul 20, 2026
@Neraste Neraste linked an issue Jul 20, 2026 that may be closed by this pull request
@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.71%. Comparing base (9f85bc3) to head (e3badbf).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #193   +/-   ##
========================================
  Coverage    98.70%   98.71%           
========================================
  Files           84       84           
  Lines         2003     2017   +14     
========================================
+ Hits          1977     1991   +14     
  Misses          26       26           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Neraste
Neraste merged commit c9602a2 into develop Jul 25, 2026
15 checks passed
@Neraste
Neraste deleted the fix/192-query branch July 25, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Current dev version searches makes it hard to find some songs

1 participant