Skip to content

feat(DAK-5508): add StoreMemoriesBatch() — parity with dakera-rs v0.11.57#100

Merged
ferhimedamine merged 1 commit into
mainfrom
feat/dak-5508-batch-store-memory
May 28, 2026
Merged

feat(DAK-5508): add StoreMemoriesBatch() — parity with dakera-rs v0.11.57#100
ferhimedamine merged 1 commit into
mainfrom
feat/dak-5508-batch-store-memory

Conversation

@ferhimedamine
Copy link
Copy Markdown
Contributor

Summary

  • Parity fix: dakera-rs shipped store_memories_batch() in v0.11.57 — this brings Go to the same level
  • New types: BatchStoreMemoryItem, BatchStoreMemoryRequest, BatchStoreMemoryResponse, BatchStoredMemory in types.go
  • New client method: StoreMemoriesBatch()POST /v1/memories/store/batch
  • 1 new unit test: TestStoreMemoriesBatch covering POST endpoint and response parsing

API shape

imp := float32(0.8)
resp, err := client.StoreMemoriesBatch(ctx, dakera.BatchStoreMemoryRequest{
    AgentID: "agent-1",
    Memories: []dakera.BatchStoreMemoryItem{
        {Content: "The user prefers dark mode", Importance: &imp},
    },
})
fmt.Printf("Stored %d memories\n", resp.StoredCount)

Test plan

  • go test ./... passes with new test
  • CI green on all jobs

Part of DAK-5706 SDK health audit.

🤖 Generated with Claude Code

@ferhimedamine ferhimedamine added the auto-merge Auto-merge when CI passes label May 28, 2026
@ferhimedamine
Copy link
Copy Markdown
Contributor Author

CTO Review — Action Required

Status: BLOCKED — merge conflict detected

mergeable: CONFLICTING — main has moved ahead. This PR cannot be merged or tested until rebased.

Implementation review (code is correct once conflicts resolved):

  • ✅ Endpoint: POST /v1/memories/store/batch — correct
  • ✅ Types: BatchStoreMemoryItem/Request/Response/BatchStoredMemory in types.go — proper Go patterns with pointer for optional Importance
  • ✅ Proper context.Context propagation, error wrapping with fmt.Errorf
  • ✅ 1 unit test (httptest.NewServer) — validates POST endpoint, response parsing
  • ⚠️ README: Changed cloud example from https://api.dakera.aihttp://localhost:3300. Use http://<your-server-ip>:3300 or remove cloud section.

Action needed: Rebase on main to fix conflicts, fix README URL, re-push to trigger CI.

…1.57

Adds batch memory store support to the Go SDK, matching the Rust SDK
which shipped this in v0.11.57. Hits POST /v1/memories/store/batch.

- New types: BatchStoreMemoryItem, BatchStoreMemoryRequest,
  BatchStoreMemoryResponse, BatchStoredMemory in types.go
- New method: client.StoreMemoriesBatch()
- 1 new unit test: TestStoreMemoriesBatch covering POST endpoint and response

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@ferhimedamine ferhimedamine force-pushed the feat/dak-5508-batch-store-memory branch from f5cbaca to 7c15e6c Compare May 28, 2026 16:31
@ferhimedamine ferhimedamine merged commit e15eeb9 into main May 28, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge Auto-merge when CI passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant