Skip to content

feat(DAK-5508): add storeMemoriesBatch() — parity with dakera-rs v0.11.57#134

Merged
ferhimedamine merged 1 commit into
mainfrom
feat/dak-5508-batch-store-memory
May 28, 2026
Merged

feat(DAK-5508): add storeMemoriesBatch() — parity with dakera-rs v0.11.57#134
ferhimedamine merged 1 commit into
mainfrom
feat/dak-5508-batch-store-memory

Conversation

@ferhimedamine
Copy link
Copy Markdown
Contributor

Summary

  • Parity fix: dakera-rs shipped store_memories_batch() in v0.11.57 — this brings JS/TS to the same level
  • New types: BatchStoreMemoryItem, BatchStoreMemoryRequest, BatchStoreMemoryResponse, BatchStoredMemory in types.ts
  • New client method: storeMemoriesBatch()POST /v1/memories/store/batch
  • Exports added to index.ts
  • 1 new unit test covering HTTP endpoint and response shape
  • Dev deps updated: @types/node 25.7→25.9.1, eslint 10.3→10.4, typescript-eslint 8.59→8.60, vitest 4.1.6→4.1.7
  • Fixed brace-expansion moderate vuln (DoS protection bypass)
  • Version bumped to 0.11.57

API shape

const resp = await client.storeMemoriesBatch({
  agent_id: 'agent-1',
  memories: [
    { content: 'The user prefers dark mode', importance: 0.8 },
    { content: 'The user is based in Berlin', importance: 0.7 },
  ],
});
console.log(`Stored ${resp.stored_count} memories`);

Test plan

  • npm test passes with new test
  • CI green on all jobs

Part of DAK-5706 SDK health audit.

🤖 Generated with Claude Code

@ferhimedamine ferhimedamine added the auto-merge Auto-merge when CI passes label May 28, 2026
@ferhimedamine
Copy link
Copy Markdown
Contributor Author

CTO Review — Action Required

Status: BLOCKED — merge conflict detected

mergeable: CONFLICTING — main has moved ahead. This PR cannot be merged or tested until rebased.

Implementation review (code is correct once conflicts resolved):

  • ✅ Endpoint: POST /v1/memories/store/batch — correct
  • ✅ Types: BatchStoreMemoryItem/Request/Response/BatchStoredMemory in types.ts — complete
  • ✅ Exports added to index.ts
  • ✅ 1 unit test (Vitest) covering HTTP endpoint + response shape
  • ✅ Dep bump: brace-expansion vuln fix, @types/node, eslint, typescript-eslint, vitest — good hygiene
  • ⚠️ README: Changed cloud example from https://api.dakera.aihttp://localhost:3300. Same issue as py PR — use http://<your-server-ip>:3300 or remove cloud section.

Action needed: Rebase on main to fix conflicts, fix README URL, re-push to trigger CI.

@ferhimedamine ferhimedamine force-pushed the feat/dak-5508-batch-store-memory branch from ab30c77 to a87a6d6 Compare May 28, 2026 16:31
…1.57

Adds batch memory store support to the JavaScript SDK, matching the Rust SDK
which shipped this in v0.11.57. Hits POST /v1/memories/store/batch.

- New interfaces: BatchStoreMemoryItem, BatchStoreMemoryRequest,
  BatchStoreMemoryResponse, BatchStoredMemory in types.ts
- New method: client.storeMemoriesBatch()
- Exports added to index.ts
- 1 new unit test covering happy path (POST endpoint, response shape)
- Updates @types/node, eslint, typescript-eslint, vitest, fixes brace-expansion vuln
- Bumps version to 0.11.57

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@ferhimedamine ferhimedamine force-pushed the feat/dak-5508-batch-store-memory branch from a87a6d6 to 44c7925 Compare May 28, 2026 16:33
@ferhimedamine ferhimedamine merged commit 7c725da into main May 28, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge Auto-merge when CI passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant