Addressing PR #56 comments#88
Open
marcusoftnet wants to merge 14 commits intoDamianEdwards:mainfrom
Open
Conversation
Author
|
Oh, there's an issue for this too . Just mentioning it here #47 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First - THANKS for RazorSlices. It's a perfect fit for HTMX and I was so happy when I found it. Hope it will gain great traction!
Secondly - I saw the great work that @jamesfoster had started in #56. Since it was some time since the comments was addressed I tried to help out by addressing them here.
In the end the changes was not that big, but I moved around some files so it looks a bit different.
Main changes are:
I have two failing tests locally, but its nothing I have touched and presumed it was due to my setup (VS Code on Linux).
I was some time since I wrote .NET on this level so please let me know if there's anything I can improve.