Skip to content

Addressing PR #56 comments#88

Open
marcusoftnet wants to merge 14 commits intoDamianEdwards:mainfrom
marcusoftnet:addressing-pr-56-comments
Open

Addressing PR #56 comments#88
marcusoftnet wants to merge 14 commits intoDamianEdwards:mainfrom
marcusoftnet:addressing-pr-56-comments

Conversation

@marcusoftnet
Copy link
Copy Markdown

First - THANKS for RazorSlices. It's a perfect fit for HTMX and I was so happy when I found it. Hope it will gain great traction!

Secondly - I saw the great work that @jamesfoster had started in #56. Since it was some time since the comments was addressed I tried to help out by addressing them here.

In the end the changes was not that big, but I moved around some files so it looks a bit different.

Main changes are:

  • Broken out to a separate HtmxTodoRoutes.cs class
  • POST, PUT and DELETE doesn't return the complete table, but individual items, which feel more inline with HTMX (ah, well REST maybe) philosophy.
  • Added a simple test for the root route of htmx-todo

I have two failing tests locally, but its nothing I have touched and presumed it was due to my setup (VS Code on Linux).

I was some time since I wrote .NET on this level so please let me know if there's anything I can improve.

@marcusoftnet
Copy link
Copy Markdown
Author

Oh, there's an issue for this too . Just mentioning it here #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants