Add demo validation CI workflow and expand demo/readiness docs - #96
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c747921240
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Generate deterministic demo media | ||
| run: npm run demo:media |
There was a problem hiding this comment.
Install Playwright browsers before capturing media
On a fresh GitHub runner, npm ci installs @playwright/test but does not provide the Chromium browser binary; in this repo chromium.launch() reports that npx playwright install is required. Because scripts/capture-demo-media.ts catches browser launch failures, writes capture-report.json, and exits successfully with only fallback storyboards, this workflow can pass the new “browser demo” validation without ever producing real browser screenshots/video. Add a Playwright browser install step (for example with dependencies) or assert browserAutomation.available before accepting the report.
Useful? React with 👍 / 👎.
Motivation
Description
.github/workflows/demo-validation.ymlto run typecheck, lint, build, a demo API unit test, deterministic demo media generation, and upload demo artifacts for PRs touching demo files.README.mdto add business-facing doc links and adjust roadmap/readiness language.docs/READINESS_HYGIENE_STATUS.md,docs/CLAIM_BOUNDARIES.md,docs/ARCHITECTURE_FUTURE_NOTES.md,docs/INTEGRATION_PRIORITIES.md,docs/PRODUCT_BOARD.md, anddocs/VALUE_MAP.mdto clarify demo boundaries and next work.docs/DEMO_READINESS_CHECKLIST.md,docs/REPO_ENV_AUDIT_2026-03-31.md,docs/REPO_REVIEW_NEXT_STEPS_2026-03-30.md, anddocs/ROADMAP.mdto reflect current posture-read/readiness changes and prioritized remediation tasks.Testing
npm run typecheck(TypeScript) in the workflow and it completed successfully.npm run lint(ESLint) in the workflow and it completed successfully.npm run buildin the workflow and the build step completed successfully.npx vitest run tests/api/demo-session-start.test.tsand it passed, followed bynpm run demo:mediawhich generatedartifacts/demo-media/capture-report.jsonand was uploaded as an artifact.Codex Task