Skip to content

Added support for making player last with sorting enabled#20

Open
MitchellMonaghan wants to merge 1 commit intoDanderBot:mainfrom
MitchellMonaghan:sortByPartyIndex
Open

Added support for making player last with sorting enabled#20
MitchellMonaghan wants to merge 1 commit intoDanderBot:mainfrom
MitchellMonaghan:sortByPartyIndex

Conversation

@MitchellMonaghan
Copy link

Feature:
Currently when you enable sorting it forces role sort on you. You cannot sort the player last without enabling sorting. I added a new check box that allows danders to still respect the party order and not use role sorting when enabled. This enables the player to be last, but still respect party order (party 1, party 2, etc). Not sure if this is how you would want to implement this feature as it could be done a number of different ways.

  1. Allow player sorting first/last without enabling sorting option
  2. Make role sort not enabled by default or have its own check box
  3. Or what I did that disables role sorting. (essentially the same thing, just a small ui difference).

I 100% vibe coded this. The one change I saw in the code that was maybe weird was in secure sort it has

if sortByPartyOrder then
    -- ignore other criteria when using raw party order
    sortEnabled = false
    sortAlphabetical = false
    sortByClass = false
end

So it works by disabling sorts, which maybe is a little odd. Let me know what you think.

Danders previously could do this, but I assume it was considered a bug with how it worked before. You had to enable sort, set your self last, then disable sort. I heal party 1-5 in dungeons and not having this sort order is really annoying. This is pretty common for arena players and less so in the pve community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant