Added support for making player last with sorting enabled#20
Open
MitchellMonaghan wants to merge 1 commit intoDanderBot:mainfrom
Open
Added support for making player last with sorting enabled#20MitchellMonaghan wants to merge 1 commit intoDanderBot:mainfrom
MitchellMonaghan wants to merge 1 commit intoDanderBot:mainfrom
Conversation
0de773a to
98781a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature:
Currently when you enable sorting it forces role sort on you. You cannot sort the player last without enabling sorting. I added a new check box that allows danders to still respect the party order and not use role sorting when enabled. This enables the player to be last, but still respect party order (party 1, party 2, etc). Not sure if this is how you would want to implement this feature as it could be done a number of different ways.
I 100% vibe coded this. The one change I saw in the code that was maybe weird was in secure sort it has
So it works by disabling sorts, which maybe is a little odd. Let me know what you think.
Danders previously could do this, but I assume it was considered a bug with how it worked before. You had to enable sort, set your self last, then disable sort. I heal party 1-5 in dungeons and not having this sort order is really annoying. This is pretty common for arena players and less so in the pve community.