Fix Health Deficit + Abbreviate (K/M) not working outside Test Mode#22
Open
andybergon wants to merge 1 commit intoDanderBot:mainfrom
Open
Fix Health Deficit + Abbreviate (K/M) not working outside Test Mode#22andybergon wants to merge 1 commit intoDanderBot:mainfrom
andybergon wants to merge 1 commit intoDanderBot:mainfrom
Conversation
The C_StringUtil code path always took priority over the abbreviation logic. Since C_StringUtil APIs are always available, the db.healthTextAbbreviate + AbbreviateNumbers branch was never reached. Fix: set the text via TruncateWhenZero + WrapString first (which correctly hides zero deficit even with secret/tainted values), then check GetText() truthiness to conditionally overwrite with the abbreviated form. This avoids comparing tainted values (which errors in instanced content) while preserving both abbreviation and zero hiding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The C_StringUtil code path always took priority over the abbreviation logic in all three deficit update functions. Since C_StringUtil APIs are always available in modern WoW, the
db.healthTextAbbreviate+AbbreviateNumbers()branch was never reached — making the Abbreviate checkbox effectively do nothing for Deficit mode.The fix sets the text via
TruncateWhenZero+WrapStringfirst (which correctly handles zero deficit with tainted/secret values), then checksGetText()truthiness to conditionally overwrite with the abbreviated form. This avoids comparing tainted values while preserving both abbreviation and zero-deficit hiding.Tested in raid (tainted values) and outside instances.
Before
After