Add Strong's and KJV definitions in JS to the Interlinear XML#2
Open
liulk wants to merge 10 commits into
Open
Conversation
- CSS fixed definitions to be ltr under rtl verses. - backported JS fixes from topic/navigation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the Strong's definitions here as an optional submodule: https://github.com/openscriptures/strongs
Subsequently, when someone checks out this repo, they could optionally run
git submodule init && git submodule updateto fetch the Strong's submodule. Once that is done, the JS for previewing Interlinear XML will use them to add<strongs-definition>and<english-definition>to the XML in browser, that can be styled using the CSS.There are no changes to the Interlinear XML files in the repo.