Improvement plan + v4.0.1–v4.1.1: correctness, contracts, maintenance, doctrine polish - #16
Open
BrodieL3 wants to merge 4 commits into
Open
Improvement plan + v4.0.1–v4.1.1: correctness, contracts, maintenance, doctrine polish#16BrodieL3 wants to merge 4 commits into
BrodieL3 wants to merge 4 commits into
Conversation
P0 correctness fixes through P3 doctrine polish, sequenced as v4.0.1 / v4.1.0 / v4.1.x. Reviewed by fable-advisor; accuracy fixes from that review applied. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0169izNJMaQTxNrLMqGnsRsj
…quirement, diff-path handoff, worktree racing Plan items 1-5 (item 17 deferred pending operator decision); CHANGELOG backfilled; version bumped. Codex lane implemented items 4-5 and the changelog; items 1-3 escalated to fable-implementer after a live approval-gate refusal. Advisor verdict: Ship. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0169izNJMaQTxNrLMqGnsRsj
…t detection, temp hygiene, pin centralization, liberal routing, manifest completeness Plan items 6-9, 12, 16 (11 deferred pending operator decision; 18 added, scheduled v4.1.x). Codex lane was refused/sandbox-blocked this wave; both work packages escalated to fable-implementer per the status contract this release codifies. Advisor verdict: Ship. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0169izNJMaQTxNrLMqGnsRsj
…plit, README accuracy, caller-routable effort Plan items 13-15, 18. Architect-typed under item 13's own exception (the delegation spec exceeded this 29-insertion diff; lane dispatches were classifier-blocked), disclosed to the reviewer. Advisor verdict: Ship. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0169izNJMaQTxNrLMqGnsRsj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The first commit adds
IMPROVEMENT_PLAN.md— a full audit of the plugin atad2bdc3with a problem / change / acceptance-criterion structure per item. The three commits after it execute the plan as three reviewed releases. Notably, the work was done with the plugin's own doctrine — codex/Luna lanes for routine typing, fable-implementer escalations, and a fable-advisor end-of-deliverable review gating every release — so several fixes were discovered live by the mechanism they fix.v4.0.1 — correctness
codex login status) so a dead login is caught beforeexecgit diff, which dies outside a repo)fable-advisor(no Bash) can actually obtain the diffs it is told to reviewv4.1.0 — contracts and maintenance
complete | partial | refused | timeout | unavailable | blocked) with an explicit architect action per status — previously onlyunavailable/timeouthad routingREASON:line added to the codex report schema; out-of-scope working-tree changes reported as unattributed (concurrent lanes/architect edits were being misattributed to codex)mktempFABLE_ADVISOR_CODEX_MODELenv override;agents/codex-implementer.mdbecomes the only normative site for the model slug (it was named in ~13 places across 5 files, and repinned three times in four weeks)license/keywords/category; per-entryversiondeliberately omitted (docs: plugin.json silently wins, so duplicating invites drift)v4.1.1 — doctrine polish
CLAUDE_CODE_SUBAGENT_MODELglobal-override consequence is stated; the codex wrapper's Sonnet cost is acknowledgedFABLE_ADVISOR_CODEX_EFFORT, defaultmax), with Model/Effort documented as spec-level routing parametersTwo plan items are deliberately deferred, with status notes in
IMPROVEMENT_PLAN.md: item 11 (CI validation workflow — fully specified, mechanical) and item 17 (broadening the anti-refusal preamble to cover approval-gate skills). Release tags (v3.1retro,v4.0.1,v4.1.0,v4.1.1) exist on the fork; tags don't travel with PRs. Happy to dropIMPROVEMENT_PLAN.mdfrom the PR or split it per-release if you'd rather take the changes piecemeal.Test plan
SPEC=/FINAL=withoutcodex exec— all PASScodex login statusexit behavior validated live on codex-cli 0.146.1🤖 Generated with Claude Code
https://claude.ai/code/session_0169izNJMaQTxNrLMqGnsRsj