Fera rework #489
Conversation
chazzyjazzy
left a comment
chazzyjazzy
left a comment
There was a problem hiding this comment.
ok - im gonna need to review this like, two more times, maybe one. i gave it a read through and understood most of what was going on, but im getting the feeling that i missed something and i was exhausted enough to just hit accept but that wont happen
| // DARKPACK EDIT CHANGE START - STORYTELLER_STATS | ||
| // ROLL TO HIT // DARKPACK TODO | ||
| // var/successes = SSroll.storyteller_roll(user.st_get_stat(STAT_DEXTERITY) + user.st_get_stat(STAT_BRAWL), 6, list(user), user) | ||
| // ROLL TO DAMAGE | ||
| var/damage_output | ||
| if(HAS_TRAIT(user, TRAIT_PERFECT_ATTACKER)) | ||
| damage_output = user.st_get_stat(STAT_STRENGTH) | ||
| else | ||
| damage_output = SSroll.storyteller_roll(user.st_get_stat(STAT_STRENGTH), 6, list(user), user, TRUE) | ||
| var/damage = (basic_mob_flags & IMMUNE_TO_FISTS) ? 0 : damage_output TTRPG_DAMAGE // DARKPACK EDIT CHANGE - STORYTELLER_STATS |
There was a problem hiding this comment.
Disclaimer I am drunk but shouldnt it be dexterity to see if they hit?
Like, the agility or speed or whatever if they miss
There was a problem hiding this comment.
It should be! It soft requires #633 so i can make the handling a bit cleaner and make sure this doesn't spam your chat.
|
|
||
| /datum/species | ||
| /// Used in get_generic_name to replace gender | ||
| var/visable_gender_override |
| @@ -0,0 +1,46 @@ | |||
| /datum/splat/werewolf/proc/examine_other_human(mob/living/carbon/examined) | |||
There was a problem hiding this comment.
perhaps some wyrmtaint stuff here?
There was a problem hiding this comment.
wyrmtaint still isn't really possible to get because we dont have da quirk.
| /** | ||
| * Gives the human a tribe, applying | ||
| * on_gain effects and post_gain effects if the | ||
| * parameter is true. Can also remove tribes | ||
| * with or without a replacement, and apply | ||
| * on_lose effects. Will have no effect the human | ||
| * is being given the tribe it already has. | ||
| * | ||
| * Arguments: | ||
| * * setting_tribe - Typepath or tribe singleton to give to the human | ||
| * * joining_round - If this tribe is being given at roundstart and should call on_join_round | ||
| */ | ||
| /mob/living/carbon/human/proc/set_fera_tribe(setting_tribe, joining_round) |
There was a problem hiding this comment.
why is this on human? can't it be on living?
There was a problem hiding this comment.
parody with clans. no strong reason atm for either type..
| /datum/splat/werewolf/proc/auspice_rank_check() | ||
| return auspice.rank_requirments(renown) | ||
|
|
||
| // Pretty iffy on this. This could likely just be moved onto the splat itself so corax and other breeds can override it. |
There was a problem hiding this comment.
Yes that is probably for the best but please do it another pr because this one is already so long
| // DARKPACK TODO - WEREWOLF - (len lore) | ||
| /datum/splat/werewolf/kinfolk/get_splat_description() | ||
| return "Lorem Ipsum" | ||
|
|
There was a problem hiding this comment.
Should probably get this and the other three filled out esp while waiting for reviews (since i dont think i should be the only review on this its so long), TFN has lore people who can help like Icey or Justice who have always helped me, or u can ask atla who made the doc
There was a problem hiding this comment.
the "len" mentioned in the comment is atlamillia.
| /datum/splat/werewolf/shifter/proc/get_breed_form_species() | ||
| return breed_form?.breed_species | ||
| /* | ||
| if(!owner?.dna) | ||
| return | ||
| return GLOB.breed_forms_list[owner.dna.features[FEATURE_FERA_BREED]] | ||
| */ |
There was a problem hiding this comment.
can probably delete that comment since get_breed_form_species seems like its doing its job, the early return if dna doesnt exist may be helpful tho
There was a problem hiding this comment.
yep! this used to be how xeon's code handled breeds but i ditched that.
| /** | ||
| * If the character is any kind of fera or kinfolk creature, named after the game line | ||
| */ | ||
| /proc/iswerewolfsplat(mob/character) |
There was a problem hiding this comment.
shouldnt all these args in this file be mob/living since splats can only exist on mob/living
There was a problem hiding this comment.
get_splat notibly exists on /mob/ atm...
parody with /proc/isvampiresplat(mob/character) which likely only exists because of its previous form as a define.
It would mean reworking all of those as well for sanity.
…s/tribes/garou.dm Co-authored-by: chazzyjazzy <33268885+chazzyjazzy@users.noreply.github.com>
chazzyjazzy
left a comment
chazzyjazzy
left a comment
There was a problem hiding this comment.
OK - tested it for a few minutes, I've reviewed it once, this PR is massive, it was TMed and it went well, I couldnt find any major bugs on local, gave it another quick review of a few files, I think its time to merge this.
really cool stuff here, alot of people will be really happy with this
5 participants
About The Pull Request
Part 1 of the fera rework: Most garou content minus 1-5 gifts
Requires #407, #657
Continuation of #122
Should fix #484
Fixes bloodpool part of #513
Playerfacing: Implements garou based upon the following document: https://docs.google.com/document/d/1ZhMsB3mToUq5Q7dk86YdyvcRfaPpq2sOxYeZKwCNEQU/edit?tab=t.0#heading=h.axkr5oqixflc
Codewise: Aims to overhaul fera onto the new splat framework and future proof the handling of splats to prevent stuff like corax just being a secret tribe of the garou and other extremely jank code.
Why It's Good For The Game
Better code c:
Alteast on Apoc, we already have plans for the bear and fox fera very soon, we need good bones for that.
Changelog
🆑
add: Readds garou
add: Moon phase is calculated mostly accurately based on in-game day
add: Rage gained from looking at the moon is now based on phase
add: Howl emote that can be used by dogs, dogs (garou), or dogs (gangrel)
add: Re-implements 1 gift for each auspice
fix: Blood-pool icon is properly updated when its added to you
admin: Adjustments to stats and important prefs can be properly viewed in the log viewers
balance: Makes generic helpers to represent "Heal this amount of "dots" of damage". Gives this to garou at 1 dot every "turn" (5 seconds at the time of writing)
balance: Punching basic mobs and humans now calculate damage based on strength
balance: W20 silver bullet handling. No agg damage in breed form. 5 bullets are a guaranteed loss of gnosis.
/:cl: