Skip to content

Charger connected state is true true when connected #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DasBasti wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Charger connected state is true true when connected #296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0aac16
fix: handle charger connection status in battery range sensor
DasBasti May 30, 2025
9206e98
fix: move charger connection status to binary sensor
DasBasti May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions custom_components/smarthashtag/binary_sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,14 @@ class SmartHashtagBinarySensorEntityDescription(BinarySensorEntityDescription):
icon="mdi:car-back",
is_on_fn=lambda state, key: state.safety.trunk_open_status == 1,
),
SmartHashtagBinarySensorEntityDescription(
key="is_charger_connected",
translation_key="is_charger_connected",
name="is charger connected",
device_class=BinarySensorDeviceClass.BATTERY_CHARGING,
icon="mdi:power-plug-battery",
is_on_fn=lambda state, key: state.battery.is_charger_connected,
),
)


Expand Down
8 changes: 2 additions & 6 deletions custom_components/smarthashtag/sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,12 +86,6 @@
device_class=SensorDeviceClass.ENUM,
entity_registry_enabled_default=False,
),
SensorEntityDescription(
key="is_charger_connected",
translation_key="is_charger_connected",
name="is charger connected",
icon="mdi:power-plug-battery",
),
SensorEntityDescription(
key="charging_voltage",
translation_key="charging_voltage",
Expand Down Expand Up @@ -1104,6 +1098,8 @@ def native_unit_of_measurement(self) -> str:
)
if "charging_status" in self.entity_description.key:
return None
if "charger_connection_status" in self.entity_description.key:
return None
if isinstance(data, ValueWithUnit):
return data.unit

Expand Down
Loading