Remove unused code for converters directory path validation#444
Open
Remove unused code for converters directory path validation#444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes redundant absolute path calculations and existence checks, the setup process is more streamlined and less prone to path-related failures (executable).
Type of Change
Check all that apply like this [x]:
Changes (by file)
Briefly list the important modified files and what was done.
DashAI/back/job/converter_job.py: Removed the logic for calculating and validating the converters directory path in instantiate_converters, reducing complexity and potential points of failure.Testing (optional)