dasharo: add Nightly DTS entry to iPXE network menu#54
Open
yuliuyi717-ux wants to merge 1 commit into
Open
Conversation
Author
|
Hi team, gentle follow-up on this one when you have a moment. This PR is the menu-entry half of Dasharo/dasharo-issues#1041, and the companion OSFV coverage PR is also ready here: So the requested implementation and test coverage are both in place on my side. If there is anything you would like adjusted before review, I’m happy to update it quickly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Dasharo Tools Suite (Nightly)to the main iPXE menu, right after the stable DTS entry:dasharo_nightlyhandler that chains tohttps://boot.dasharo.com/dts/nightly.ipxedhcp || chain || goto MENU)Why
Issue
Dasharo/dasharo-issues#1041requests exposing nightly DTS builds directly from the Dasharo iPXE menu.Notes
OSFV test updates are submitted in a companion PR:
Dasharo/open-source-firmware-validation(network-boot menu order + nightly option coverage)Fixes Dasharo/dasharo-issues#1041