Added option click location to refresh window before searching for waitForText and waitForImage#16
Open
wzydhek wants to merge 2 commits intoDashingStrike:masterfrom
wzydhek:master
Open
Added option click location to refresh window before searching for waitForText and waitForImage#16wzydhek wants to merge 2 commits intoDashingStrike:masterfrom wzydhek:master
wzydhek wants to merge 2 commits intoDashingStrike:masterfrom
wzydhek:master
Conversation
Contributor
|
So I can see the use here, but I'm not in love with the structure of how this works. The problems I see are that it potentially clicks pretty aggressively to update (limited only by time to screen scrape and tick_time if it's set), and due to the static nature of where it clicks has a decent chance of getting into a situation where a window moves and now the macro clicks a spot on the screen nonstop. It also can't update multiple windows. If you need to potentially click to check to see if a window has updated, I would recommend this: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.